Issue 1433023003: New Mojom parser: Fix serialization of arrays and maps.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1433023003: New Mojom parser: Fix serialization of arrays and maps. (Closed)

Created:
5 years, 1 month ago by rudominer

Modified:
5 years, 1 month ago

Reviewers:
azani

CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Fix serialization of arrays and maps. R=azani@chromium.org BUG=#461 Committed: https://chromium.googlesource.com/external/mojo/+/bd692edd4755490c6805294b9e1ba219288fe23b

Patch Set 1 #

Patch Set 2 : Upadates the sha1 of the parser binary. #

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+123 lines, -3 lines)			Patch
M	mojom/mojom_parser/bin/linux64/mojom_parser.sha1	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	mojom/mojom_parser/serialization/serialization.go	View		2 chunks	+6 lines, -2 lines	0 comments	Download
M	mojom/mojom_parser/serialization/serialization_test.go	View		1 chunk	+116 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

rudominer

Hi Alex, ptal. This addresses a remark of yours in https://codereview.chromium.org/1421193003/

5 years, 1 month ago (2015-11-11 01:30:21 UTC) #3

rudominer

5 years, 1 month ago (2015-11-11 02:07:15 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
bd692edd4755490c6805294b9e1ba219288fe23b (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages