Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(616)

Unified Diff: mojom/mojom_parser/serialization/serialization.go

Issue 1433023003: New Mojom parser: Fix serialization of arrays and maps. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Upadates the sha1 of the parser binary. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojom/mojom_parser/serialization/serialization.go
diff --git a/mojom/mojom_parser/serialization/serialization.go b/mojom/mojom_parser/serialization/serialization.go
index f114660e8640c09adafdb006d9faea66bb23f1ab..80a72415f4537679434f069661b39246d0557cad 100644
--- a/mojom/mojom_parser/serialization/serialization.go
+++ b/mojom/mojom_parser/serialization/serialization.go
@@ -308,8 +308,12 @@ func translateTypeRef(typeRef mojom.TypeRef) mojom_types.Type {
case mojom.HandleTypeRef:
return translateHandleType(t)
case mojom.ArrayTypeRef:
+ return translateArrayType(&t)
+ case *mojom.ArrayTypeRef:
return translateArrayType(t)
case mojom.MapTypeRef:
+ return translateMapType(&t)
+ case *mojom.MapTypeRef:
return translateMapType(t)
case *mojom.UserTypeRef:
return translateUserTypeRef(t)
@@ -368,14 +372,14 @@ func translateHandleType(handleType mojom.HandleTypeRef) *mojom_types.TypeHandle
return &mojom_types.TypeHandleType{mojom_types.HandleType{handleType.Nullable(), kind}}
}
-func translateArrayType(arrayType mojom.ArrayTypeRef) *mojom_types.TypeArrayType {
+func translateArrayType(arrayType *mojom.ArrayTypeRef) *mojom_types.TypeArrayType {
return &mojom_types.TypeArrayType{mojom_types.ArrayType{
Nullable: arrayType.Nullable(),
FixedLength: int32(arrayType.FixedLength()),
ElementType: translateTypeRef(arrayType.ElementType())}}
}
-func translateMapType(mapType mojom.MapTypeRef) *mojom_types.TypeMapType {
+func translateMapType(mapType *mojom.MapTypeRef) *mojom_types.TypeMapType {
return &mojom_types.TypeMapType{mojom_types.MapType{
Nullable: mapType.Nullable(),
KeyType: translateTypeRef(mapType.KeyType()),
« no previous file with comments | « mojom/mojom_parser/bin/linux64/mojom_parser.sha1 ('k') | mojom/mojom_parser/serialization/serialization_test.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698