Bindings generator should support Web IDL callback interfaces

Bindings generator should support Web IDL callback interfaces

Add support in the bindings generator for Web IDL callback interfaces:
http://dev.w3.org/2006/webapi/WebIDL/#dfn-callback-interface

Drop support for the Blink-specific [Callback] extended attributes
on Web IDL interfaces and update existing IDL files to use proper
callback interfaces instead.

BUG=235438
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=149160

[do-not-use, 2013-04-25 14:55:07]

Using standard Web IDL seems to be one of the goals for blink.

From http://www.chromium.org/blink#architectural-changes:
"Replace WebKitIDL with WebIDL and remove custom JavaScript bindings code"

[haraken, 2013-04-25 14:59:17]

LGTM

[arv (Not doing code reviews), 2013-04-25 16:33:48]

LGTM

[commit-bot: I haz the power, 2013-04-25 16:39:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/14329023/1

[commit-bot: I haz the power, 2013-04-25 16:39:17]

Failed to apply patch for
Source/modules/mediastream/NavigatorUserMediaSuccessCallback.idl:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/modules/mediastream/NavigatorUserMediaSuccessCallback.idl
  Hunk #1 FAILED at 23.
  1 out of 1 hunk FAILED -- saving rejects to file
Source/modules/mediastream/NavigatorUserMediaSuccessCallback.idl.rej

Patch:       Source/modules/mediastream/NavigatorUserMediaSuccessCallback.idl
Index: Source/modules/mediastream/NavigatorUserMediaSuccessCallback.idl
diff --git a/Source/modules/mediastream/NavigatorUserMediaSuccessCallback.idl
b/Source/modules/mediastream/NavigatorUserMediaSuccessCallback.idl
index
967445990815560587f697bd8adcf0b992499a78..4cf2ea83bb5eb87a22fc0a1512419b0dd92d3cdc
100644
--- a/Source/modules/mediastream/NavigatorUserMediaSuccessCallback.idl
+++ b/Source/modules/mediastream/NavigatorUserMediaSuccessCallback.idl
@@ -23,9 +23,8 @@
  */
 
 [
-    Conditional=MEDIA_STREAM,
-    Callback
-] interface NavigatorUserMediaSuccessCallback {
+    Conditional=MEDIA_STREAM
+] callback interface NavigatorUserMediaSuccessCallback {
     boolean handleEvent(LocalMediaStream stream);
 };

[do-not-use, 2013-04-25 18:33:12]

On 2013/04/25 16:39:17, I haz the power (commit-bot) wrote:
> Failed to apply patch for
> Source/modules/mediastream/NavigatorUserMediaSuccessCallback.idl:
> While running patch -p1 --forward --force --no-backup-if-mismatch;
>   patching file
Source/modules/mediastream/NavigatorUserMediaSuccessCallback.idl
>   Hunk #1 FAILED at 23.
>   1 out of 1 hunk FAILED -- saving rejects to file
> Source/modules/mediastream/NavigatorUserMediaSuccessCallback.idl.rej
> 
> Patch:       Source/modules/mediastream/NavigatorUserMediaSuccessCallback.idl
> Index: Source/modules/mediastream/NavigatorUserMediaSuccessCallback.idl
> diff --git a/Source/modules/mediastream/NavigatorUserMediaSuccessCallback.idl
> b/Source/modules/mediastream/NavigatorUserMediaSuccessCallback.idl
> index
>
967445990815560587f697bd8adcf0b992499a78..4cf2ea83bb5eb87a22fc0a1512419b0dd92d3cdc
> 100644
> --- a/Source/modules/mediastream/NavigatorUserMediaSuccessCallback.idl
> +++ b/Source/modules/mediastream/NavigatorUserMediaSuccessCallback.idl
> @@ -23,9 +23,8 @@
>   */
>  
>  [
> -    Conditional=MEDIA_STREAM,
> -    Callback
> -] interface NavigatorUserMediaSuccessCallback {
> +    Conditional=MEDIA_STREAM
> +] callback interface NavigatorUserMediaSuccessCallback {
>      boolean handleEvent(LocalMediaStream stream);
>  };

Rebased on master. Could someone please cq+ again?

[commit-bot: I haz the power, 2013-04-25 19:08:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/14329023/5001

[commit-bot: I haz the power, 2013-04-25 19:08:47]

Presubmit check for 14329023-5001 failed and returned exit status 1.

INFO:root:Found 32 file(s).
Running presubmit commit checks ...
Running /b/commit-queue/workdir/blink/PRESUBMIT.py

** Presubmit ERRORS **
Missing LGTM from an OWNER for these files:
    Source/modules/filesystem/EntriesCallback.idl
    Source/modules/filesystem/EntryCallback.idl
    Source/modules/filesystem/ErrorCallback.idl
    Source/modules/filesystem/FileCallback.idl
    Source/modules/filesystem/FileSystemCallback.idl
    Source/modules/filesystem/FileWriterCallback.idl
    Source/modules/filesystem/MetadataCallback.idl
    Source/modules/geolocation/PositionCallback.idl
    Source/modules/geolocation/PositionErrorCallback.idl
    Source/modules/mediastream/NavigatorUserMediaErrorCallback.idl
    Source/modules/mediastream/NavigatorUserMediaSuccessCallback.idl
    Source/modules/mediastream/RTCErrorCallback.idl
    Source/modules/mediastream/RTCSessionDescriptionCallback.idl
    Source/modules/mediastream/RTCStatsCallback.idl
    Source/modules/notifications/NotificationPermissionCallback.idl
    Source/modules/quota/StorageErrorCallback.idl
    Source/modules/quota/StorageQuotaCallback.idl
    Source/modules/quota/StorageUsageCallback.idl
    Source/modules/webaudio/AudioBufferCallback.idl
    Source/modules/webdatabase/DatabaseCallback.idl
    Source/modules/webdatabase/SQLStatementCallback.idl
    Source/modules/webdatabase/SQLStatementErrorCallback.idl
    Source/modules/webdatabase/SQLTransactionCallback.idl
    Source/modules/webdatabase/SQLTransactionErrorCallback.idl
    Source/modules/webdatabase/SQLTransactionSyncCallback.idl
    Source/modules/webmidi/MIDIErrorCallback.idl

Presubmit checks took 2.1s to calculate.

[haraken, 2013-04-25 19:10:13]

abarth: rubber-stamp for modules/ please?

[abarth-chromium, 2013-04-26 04:10:44]

LGTM.  haraken should be able to review these IDL changes in modules.  I'm not
sure why the per-file IDL thing isn't working...  Maybe that OWNERS file fails
to parse entirely.

[commit-bot: I haz the power, 2013-04-26 04:18:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/14329023/5001

[commit-bot: I haz the power, 2013-04-26 04:41:47]

Change committed as 149160

[jochen (gone - plz use gerrit), 2013-04-26 06:47:58]

filed crbug.com/235756 about the owners issue

[do-not-use, 2013-04-26 07:17:29]

Note that http://www.chromium.org/blink/webidl needs updating now.
However, I do not seem to have the rights to edit that page.

I updated the WebKit wiki though:
http://trac.webkit.org/wiki/WebKitIDL?action=diff&version=87&old_version=85

Could someone please give me the rights to edit the Blink WebIDL page? or
alternatively do the update for me. TIA.

[abarth-chromium, 2013-04-26 17:06:29]

I think we just need to nominate you as a committer.  I'll do that today.

[haraken, 2013-04-26 19:19:59]

On 2013/04/26 17:06:29, abarth wrote:
> I think we just need to nominate you as a committer.  I'll do that today.

I'll write a big +1 :)

[do-not-use, 2013-04-26 23:40:07]

On 2013/04/26 19:19:59, haraken wrote:
> On 2013/04/26 17:06:29, abarth wrote:
> > I think we just need to nominate you as a committer.  I'll do that today.
> 
> I'll write a big +1 :)

Great, thanks!