Source/bindings/scripts/CodeGeneratorV8.pm - Issue 14329023: Bindings generator should support Web IDL callback interfaces

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/scripts/CodeGeneratorV8.pm

Issue 14329023: Bindings generator should support Web IDL callback interfaces (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebase on master Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/scripts/CodeGeneratorV8.pm

diff --git a/Source/bindings/scripts/CodeGeneratorV8.pm b/Source/bindings/scripts/CodeGeneratorV8.pm

index 888692c040e9433ba389e0c191eda16c2fa12e19..9d3be35476b07f5341c6e0188df568d7713d1cd1 100644

--- a/Source/bindings/scripts/CodeGeneratorV8.pm

+++ b/Source/bindings/scripts/CodeGeneratorV8.pm

@@ -80,7 +80,7 @@ sub GenerateInterface

my $interface = shift;

# Start actual generation

- if ($interface->extendedAttributes->{"Callback"}) {

+ if ($interface->isCallback) {

$object->GenerateCallbackHeader($interface);

$object->GenerateCallbackImplementation($interface);

} else {

« no previous file with comments | « no previous file | Source/bindings/scripts/IDLParser.pm » ('j') | no next file with comments »