Issue 14329008: Add new ovals GM

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14329008: Add new ovals GM (Closed)

Created:
7 years, 8 months ago by jvanverth1

Modified:
7 years, 8 months ago

Reviewers:
robertphillips

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Add new ovals GM. Add a GM to test ovals with a variety of paint settings, matrices and sizes.

Patch Set 2 : Add gradient shader #

Patch Set 3 : Remove commented out code; change random number generator #

Total comments: 7

Patch Set 4 : Fixed nits, colors #

Patch Set 5 : Add AutoTUnref #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+286 lines, -0 lines)			Patch
	A	gm/ovals.cpp	View	1 2 3 4	1 chunk	+285 lines, -0 lines	0 comments	Download
	M	gyp/gmslides.gypi	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

robertphillips

lgtm + nits/suggestions https://codereview.chromium.org/14329008/diff/8001/gm/ovals.cpp File gm/ovals.cpp (right): https://codereview.chromium.org/14329008/diff/8001/gm/ovals.cpp#newcode2 gm/ovals.cpp:2: /* wrong date Not Intel either ...

7 years, 8 months ago (2013-04-17 21:48:58 UTC) #2

Message was sent while issue was closed.

Committed as r8737.