Issue 1432833002: Merge to M46: Enforce input and output dimensionalities for CPDF_StitchFunc.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1432833002: Merge to M46: Enforce input and output dimensionalities for CPDF_StitchFunc. (Closed)

Created:
5 years, 1 month ago by Oliver Chang

Modified:
5 years, 1 month ago

Reviewers:
Lei Zhang

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@2490

Target Ref:
refs/heads/chromium/2490

Visibility:
Public.

More Reviews

Description

Merge to M46: Enforce input and output dimensionalities for CPDF_StitchFunc. Also cleans up some places in the relevant functions since we're here. BUG=551460 R=thestig@chromium.org Review URL: https://codereview.chromium.org/1421783004 . (cherry picked from commit 4f85605cbc652a17bc833f883186e0a68af6006d) Committed: https://pdfium.googlesource.com/pdfium/+/1c27b89fde2f49d9db25e24c8f84a4dca39224d1

Patch Set 1 #

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+227 lines, -29 lines)			Patch
M	BUILD.gn	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	core/src/fpdfapi/fpdf_page/fpdf_page_func.cpp	View	3 chunks	+41 lines, -29 lines	0 comments	Download
A	core/src/fpdfapi/fpdf_page/fpdf_page_func_embeddertest.cpp	View	1 chunk	+20 lines, -0 lines	0 comments	Download
M	pdfium.gyp	View	1 chunk	+1 line, -0 lines	0 comments	Download
A	testing/resources/bug_551460.in	View	1 chunk	+75 lines, -0 lines	0 comments	Download
A	testing/resources/bug_551460.pdf	View	1 chunk	+89 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Oliver Chang

ptal. minor conflict because of https://codereview.chromium.org/1321293003

5 years, 1 month ago (2015-11-06 22:41:11 UTC) #1

Oliver Chang

Committed patchset #1 (id:1) manually as 1c27b89fde2f49d9db25e24c8f84a4dca39224d1 (presubmit successful).

5 years, 1 month ago (2015-11-06 22:50:57 UTC) #3

Oliver Chang

5 years, 1 month ago (2015-11-06 22:51:21 UTC) #4

Message was sent while issue was closed.

On 2015/11/06 22:50:57, Oliver Chang wrote:
> Committed patchset #1 (id:1) manually as
> 1c27b89fde2f49d9db25e24c8f84a4dca39224d1 (presubmit successful).

Please take care of the DEPS roll :)

Expand Messages | Collapse Messages