Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 1421783004: Enforce input and output dimensionalities for CPDF_StitchFunc. (Closed)

Created:
5 years, 1 month ago by Oliver Chang
Modified:
5 years, 1 month ago
Reviewers:
Lei Zhang, Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Enforce input and output dimensionalities for CPDF_StitchFunc. Also cleans up some places in the relevant functions since we're here. BUG=551460 R=tsepez@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/4f85605cbc652a17bc833f883186e0a68af6006d

Patch Set 1 #

Patch Set 2 : test #

Patch Set 3 : oops #

Patch Set 4 : nit #

Total comments: 8

Patch Set 5 : address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+226 lines, -28 lines) Patch
M BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M core/src/fpdfapi/fpdf_page/fpdf_page_func.cpp View 1 2 3 4 3 chunks +40 lines, -28 lines 0 comments Download
A core/src/fpdfapi/fpdf_page/fpdf_page_func_embeddertest.cpp View 1 2 3 1 chunk +20 lines, -0 lines 0 comments Download
M pdfium.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download
A testing/resources/bug_551460.in View 1 1 chunk +75 lines, -0 lines 0 comments Download
A testing/resources/bug_551460.pdf View 1 2 3 4 1 chunk +89 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
Oliver Chang
ptal
5 years, 1 month ago (2015-11-04 21:52:51 UTC) #6
Tom Sepez
lgtm https://codereview.chromium.org/1421783004/diff/100001/core/src/fpdfapi/fpdf_page/fpdf_page_func.cpp File core/src/fpdfapi/fpdf_page/fpdf_page_func.cpp (right): https://codereview.chromium.org/1421783004/diff/100001/core/src/fpdfapi/fpdf_page/fpdf_page_func.cpp#newcode749 core/src/fpdfapi/fpdf_page/fpdf_page_func.cpp:749: if (pDict == NULL) { nit: !pDict https://codereview.chromium.org/1421783004/diff/100001/core/src/fpdfapi/fpdf_page/fpdf_page_func.cpp#newcode756 ...
5 years, 1 month ago (2015-11-04 22:10:54 UTC) #8
Oliver Chang
thanks for review! https://codereview.chromium.org/1421783004/diff/100001/core/src/fpdfapi/fpdf_page/fpdf_page_func.cpp File core/src/fpdfapi/fpdf_page/fpdf_page_func.cpp (right): https://codereview.chromium.org/1421783004/diff/100001/core/src/fpdfapi/fpdf_page/fpdf_page_func.cpp#newcode749 core/src/fpdfapi/fpdf_page/fpdf_page_func.cpp:749: if (pDict == NULL) { On ...
5 years, 1 month ago (2015-11-04 22:18:58 UTC) #9
Oliver Chang
5 years, 1 month ago (2015-11-04 22:23:37 UTC) #10
Message was sent while issue was closed.
Committed patchset #5 (id:120001) manually as
4f85605cbc652a17bc833f883186e0a68af6006d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698