Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1843)

Unified Diff: chrome/browser/extensions/service_worker_apitest.cc

Issue 1432823003: Add a test to cover service worker update codepath when extension is updated (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address comments + git cl format Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/service_worker_apitest.cc
diff --git a/chrome/browser/extensions/service_worker_apitest.cc b/chrome/browser/extensions/service_worker_apitest.cc
index 29fad8fa5aa7285fc66d58454b3be8d38db67766..8387203db081f93d54dc8ac7843c9ecb97317493 100644
--- a/chrome/browser/extensions/service_worker_apitest.cc
+++ b/chrome/browser/extensions/service_worker_apitest.cc
@@ -15,6 +15,7 @@
#include "content/public/common/page_type.h"
#include "content/public/test/browser_test_utils.h"
#include "extensions/browser/extension_host.h"
+#include "extensions/browser/extension_registry.h"
#include "extensions/browser/process_manager.h"
#include "extensions/test/background_page_watcher.h"
#include "extensions/test/extension_test_message_listener.h"
@@ -132,6 +133,43 @@ IN_PROC_BROWSER_TEST_F(ServiceWorkerTest, RegisterFailsOnDev) {
error);
}
+IN_PROC_BROWSER_TEST_F(ServiceWorkerTest, UpdateRefreshesServiceWorker) {
+ base::ScopedTempDir scoped_temp_dir;
+ ASSERT_TRUE(scoped_temp_dir.CreateUniqueTempDir());
+ base::FilePath pem_path = test_data_dir_.AppendASCII("service_worker")
+ .AppendASCII("update")
+ .AppendASCII("service_worker.pem");
+ base::FilePath path_v1 = PackExtensionWithOptions(
+ test_data_dir_.AppendASCII("service_worker")
+ .AppendASCII("update")
+ .AppendASCII("v1"),
+ scoped_temp_dir.path().AppendASCII("v1.crx"), pem_path, base::FilePath());
+ base::FilePath path_v2 = PackExtensionWithOptions(
+ test_data_dir_.AppendASCII("service_worker")
+ .AppendASCII("update")
+ .AppendASCII("v2"),
+ scoped_temp_dir.path().AppendASCII("v2.crx"), pem_path, base::FilePath());
+
+ const char* kId = "hfaanndiiilofhfokeanhddpkfffchdi";
+
+ // Install version 1.0 of the extension.
+ ASSERT_TRUE(InstallExtension(path_v1, 1));
+ EXPECT_TRUE(extensions::ExtensionRegistry::Get(profile())
+ ->enabled_extensions()
+ .GetByID(kId) != NULL);
+
+ const char* kScript = "window.testResolver();";
+ EXPECT_EQ("Pong from version 1", ExecuteScriptInBackgroundPage(kId, kScript));
+
+ // Update to version 2.0.
+ EXPECT_TRUE(UpdateExtension(kId, path_v2, 0));
+ EXPECT_TRUE(extensions::ExtensionRegistry::Get(profile())
+ ->enabled_extensions()
+ .GetByID(kId) != NULL);
+
+ EXPECT_EQ("Pong from version 2", ExecuteScriptInBackgroundPage(kId, kScript));
+}
+
IN_PROC_BROWSER_TEST_F(ServiceWorkerTest, FetchArbitraryPaths) {
const Extension* extension =
StartTestFromBackgroundPage("fetch.js", kExpectSuccess);

Powered by Google App Engine
This is Rietveld 408576698