Add a test to cover service worker update codepath when extension is updated

content/browser/service_worker/service_worker_context_wrapper.cc

Index: content/browser/service_worker/service_worker_context_wrapper.cc
diff --git a/content/browser/service_worker/service_worker_context_wrapper.cc b/content/browser/service_worker/service_worker_context_wrapper.cc
index aaa375848dd8565094dce92a1fd6447833f22803..6095aab94d72a64e0eb27fe4420d89e1b0cd232c 100644
--- a/content/browser/service_worker/service_worker_context_wrapper.cc
+++ b/content/browser/service_worker/service_worker_context_wrapper.cc
@@ -332,6 +332,13 @@ void ServiceWorkerContextWrapper::DidGetAllRegistrationsForGetAllOrigins(
   callback.Run(usage_infos);
 }
 
+void ServiceWorkerContextWrapper::DidGetRegistrationsForForceUpdateForOrigin(
+    const std::vector<scoped_refptr<ServiceWorkerRegistration>>&
+        registrations) {
+  for (const auto& registration : registrations)
+    registration->set_force_update_on_page_load(true);

[falken, 2015/11/17 02:10:22]

This is a hacky bit used for the "Force update on page load" checkbox in
DevTools. If you set this bit, all page loads in the scope of these service
workers are blocked until the worker updates. The worker will update each time
regardless of whether the worker script changed.

In this patch, I see a couple problems with this approach:
- The bit is never unset. So all page loads in this extension will block on an
update.
- This still looks racy since SetForceUpdateOnPageLoadForOrigin calls the async
function GetRegistrationsForOrigin.

I'm wondering if it's really necessary for the updated sw to be active the next
time the extension is accessed, or if this can be more in the spirit of the SW
update model: can extension sw's have soft updates like web sw's (we can also
schedule one when the extension is updated). The author can additionally use the
SW API to force update when needed: e.g., with
ServiceWorkerRegistration.update() and skipWaiting()/claim().

[Devlin, 2015/11/17 19:23:56]

Dang - that bit looked so promising! ;)

Scheduling an update when the extension is updated sounds perfect (and was the
goal of this CL - we just want to make sure we don't have to wait for the normal
24-hour period) - can you give us a pointer to how we would do that?

+}
+
 void ServiceWorkerContextWrapper::DidCheckHasServiceWorker(
     const CheckHasServiceWorkerCallback& callback,
     bool has_service_worker) {
@@ -411,6 +418,27 @@ void ServiceWorkerContextWrapper::DeleteForOrigin(
       origin.GetOrigin(), base::Bind(&StatusCodeToBoolCallbackAdapter, result));
 }
 
+void ServiceWorkerContextWrapper::SetForceUpdateOnPageLoadForOrigin(
+    const GURL& origin) {
+  if (!BrowserThread::CurrentlyOn(BrowserThread::IO)) {
+    BrowserThread::PostTask(
+        BrowserThread::IO, FROM_HERE,
+        base::Bind(
+            &ServiceWorkerContextWrapper::SetForceUpdateOnPageLoadForOrigin,
+            this, origin));
+    return;
+  }
+
+  if (!context_core_)
+    return;
+
+  context_core_->storage()->GetRegistrationsForOrigin(
+      origin.GetOrigin(),
+      base::Bind(&ServiceWorkerContextWrapper::
+                     DidGetRegistrationsForForceUpdateForOrigin,
+                 this));
+}
+
 void ServiceWorkerContextWrapper::CheckHasServiceWorker(
     const GURL& url,
     const GURL& other_url,