Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(758)

Issue 14328034: Revert 195090 "clang: Build in C++11 mode on linux & cros too." (Closed)

Created:
7 years, 8 months ago by Nico
Modified:
7 years, 8 months ago
Reviewers:
Nico
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 195090 "clang: Build in C++11 mode on linux & cros too." Broke chromeos clang builder: Complains about libstdc++ 4.4, but is probably not yet on precise. Broke linux clang tests: unit_tests, content_unittests, components_unittests all crash at startup with: symbol lookup error: /b/build/slave/Linux_Clang__dbg_/build/src/out/Debug/lib/libcontent.so: undefined symbol: _ZN7content6Zygote26kMagicSandboxIPCDescriptorE > clang: Build in C++11 mode on linux & cros too. > > But: Not yet on Android, not yet with asan, not yet with gcc. > Only with clang, and only for linux & cros (in addition to mac, > which has had this for a while). > > BUG=233330, 233464 > > Review URL: https://codereview.chromium.org/11468005 TBR=thakis@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195091

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -42 lines) Patch
M trunk/src/build/common.gypi View 3 chunks +11 lines, -42 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Nico
7 years, 8 months ago (2013-04-19 04:52:40 UTC) #1
Nico
7 years, 8 months ago (2013-04-19 04:52:55 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r195091.

Powered by Google App Engine
This is Rietveld 408576698