Issue 11468005: clang: Build in C++11 mode on linux & cros too.

Issue 11468005: clang: Build in C++11 mode on linux & cros too. (Closed)

Created:
8 years ago by Nico

Modified:
7 years, 7 months ago

Reviewers:
awong

CC:
chromium-reviews, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

clang: Build in C++11 mode on linux too. But: Not yet on Android, not yet on cros, not yet with gcc. Only with clang, and only for linux (in addition to mac, which has had this for a while). (The cros main waterfall bot isn't on precise yet. Android's stdlib cannot handle C++11.) BUG=233330, 233464 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195090 R=ajwong@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=197483

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : rebase #

Patch Set 4 : . #

Patch Set 5 : . #

Patch Set 6 : 64vs32bit always false #

Patch Set 7 : history #

Patch Set 8 : jln #

Patch Set 9 : rebase #

Patch Set 10 : android #

Patch Set 11 : asan #

Patch Set 12 : asan #

Patch Set 13 : reupload #

Patch Set 14 : rebase #

Patch Set 15 : rebase-er #

Patch Set 16 : asan in, cros out #

Total comments: 1

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+42 lines, -11 lines)			Patch
	M	build/common.gypi	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14 15	3 chunks	+42 lines, -11 lines	1 comment	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Nico

Committed patchset #16 manually as r197483 (presubmit successful).

7 years, 7 months ago (2013-04-30 21:40:51 UTC) #3

tfarina

https://codereview.chromium.org/11468005/diff/29002/build/common.gypi File build/common.gypi (right): https://codereview.chromium.org/11468005/diff/29002/build/common.gypi#newcode3043 build/common.gypi:3043: '-std=gnu++11', looks like this broke my build, and the ...

7 years, 7 months ago (2013-05-01 23:44:55 UTC) #4

Nico

7 years, 7 months ago (2013-05-02 00:32:00 UTC) #5

The instructions are the same, nothing should change (assuming you have GCC
4.6 on your Linux system). What platform are you on? What compiler version?
On May 1, 2013 4:44 PM, <tfarina@chromium.org> wrote:

>
>
https://codereview.chromium.**org/11468005/diff/29002/build/**common.gypi<htt...
> File build/common.gypi (right):
>
> https://codereview.chromium.**org/11468005/diff/29002/build/**
>
common.gypi#newcode3043<https://codereview.chromium.org/11468005/diff/29002/build/common.gypi#newcode3043>
> build/common.gypi:3043: '-std=gnu++11',
> looks like this broke my build, and the instructions were not updated?
>
https://code.google.com/p/**chromium/wiki/**LinuxBuildInstructions<https://co...
>
>
https://codereview.chromium.**org/11468005/<https://codereview.chromium.org/1...
>

Expand Messages | Collapse Messages