Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 143263014: Cleanup GrGLInterface factories in Chromium in order to remove old names and workaround code in Ski… (Closed)

Created:
6 years, 10 months ago by bsalomon
Modified:
6 years, 9 months ago
Reviewers:
piman
CC:
chromium-reviews, piman+watch_chromium.org
Visibility:
Public.

Description

Cleanup GrGLInterface factories in Chromium in order to remove old names and workaround code in Skia. Skia-side change at https://codereview.chromium.org/149533002/ Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=254157

Patch Set 1 #

Patch Set 2 : Ensure GL context is current before calling GrGLInterface factory. #

Patch Set 3 : rebase to ToT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+252 lines, -234 lines) Patch
M cc/test/test_in_process_context_provider.cc View 1 2 chunks +5 lines, -2 lines 0 comments Download
M content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M gpu/skia_bindings/gl_bindings_skia_cmd_buffer.cc View 1 chunk +113 lines, -106 lines 0 comments Download
M ui/gl/gl_bindings_skia_in_process.cc View 2 chunks +132 lines, -126 lines 0 comments Download
M webkit/common/gpu/webgraphicscontext3d_in_process_command_buffer_impl.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
bsalomon
6 years, 10 months ago (2014-01-29 13:33:23 UTC) #1
piman
lgtm
6 years, 10 months ago (2014-01-29 19:11:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bsalomon@google.com/143263014/1
6 years, 10 months ago (2014-01-29 19:21:23 UTC) #3
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) cc_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=218114
6 years, 10 months ago (2014-01-29 20:10:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bsalomon@google.com/143263014/20001
6 years, 10 months ago (2014-01-29 22:05:16 UTC) #5
commit-bot: I haz the power
Retried try job too often on android_clang_dbg for step(s) slave_steps http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_clang_dbg&number=110693
6 years, 10 months ago (2014-01-29 23:04:06 UTC) #6
bsalomon
The CQ bit was checked by bsalomon@google.com
6 years, 9 months ago (2014-02-28 14:31:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bsalomon@google.com/143263014/40001
6 years, 9 months ago (2014-02-28 14:34:20 UTC) #8
commit-bot: I haz the power
6 years, 9 months ago (2014-02-28 16:53:49 UTC) #9
Message was sent while issue was closed. 
Change committed as 254157

Powered by Google App Engine
This is Rietveld 408576698