Generalize ContextualSearchEdgeSwipeHandler

Generalize ContextualSearchEdgeSwipeHandler

This change generalizes the swipe event handler so it can be
handled by any panel.

BUG=521773
Committed: https://crrev.com/4a29955fa85fd11c11e311c33173c89a58fe27b7
Cr-Commit-Position: refs/heads/master@{#359015}

[mdjones, 2015-11-03 20:03:51]

mdjones@chromium.org changed reviewers:
+ dtrainor@chromium.org, pedrosimonetti@chromium.org

[mdjones, 2015-11-03 20:03:52]

PTAL

[David Trainor- moved to gerrit, 2015-11-04 00:39:41]

lgtm with nit.

https://codereview.chromium.org/1432613002/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerDocument.java
(right):

https://codereview.chromium.org/1432613002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerDocument.java:375:
&& panel.supportsOverlayPanelLayout()) {
null check panel here?  you do it below.

[mdjones, 2015-11-04 01:45:28]

https://codereview.chromium.org/1432613002/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerDocument.java
(right):

https://codereview.chromium.org/1432613002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerDocument.java:375:
&& panel.supportsOverlayPanelLayout()) {
On 2015/11/04 00:39:41, David Trainor wrote:
> null check panel here?  you do it below.

Done.

[pedro (no code reviews), 2015-11-04 21:03:16]

lgtm

https://codereview.chromium.org/1432613002/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanel.java
(right):

https://codereview.chromium.org/1432613002/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanel.java:399:
public boolean supportsOverlayPanelLayout() {
Nit: The OverlayPanelLayout does not exist yet. We are still using the
ContextualSearchLayout. For this reason I would call this
supportsContextualSearchLayout() and put a TODO to rename it once the layout is
renamed.

https://codereview.chromium.org/1432613002/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerDocument.java
(right):

https://codereview.chromium.org/1432613002/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerDocument.java:379:
if (panel != null && !panel.onInterceptBarSwipe()) {
Thanks for addressing my offline comments. The code is much better now. It
doesn't know about compatibility mode, neither about the
ContextualSearchDelegate. It doesn't have an early return. The conditions to
show the layout and intercept the swipe are not implicit anymore.

https://codereview.chromium.org/1432613002/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerDocument.java:387:
&& mOverlayPanelManager.getActivePanel() != null;
I would still check activePanel.isShowing(), even if we are currently assuming
that an active Panels is always showing.

[mdjones, 2015-11-04 23:25:08]

https://codereview.chromium.org/1432613002/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanel.java
(right):

https://codereview.chromium.org/1432613002/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanel.java:399:
public boolean supportsOverlayPanelLayout() {
On 2015/11/04 21:03:15, pedrosimonetti wrote:
> Nit: The OverlayPanelLayout does not exist yet. We are still using the
> ContextualSearchLayout. For this reason I would call this
> supportsContextualSearchLayout() and put a TODO to rename it once the layout
is
> renamed.

Done.

https://codereview.chromium.org/1432613002/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerDocument.java
(right):

https://codereview.chromium.org/1432613002/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerDocument.java:387:
&& mOverlayPanelManager.getActivePanel() != null;
On 2015/11/04 21:03:15, pedrosimonetti wrote:
> I would still check activePanel.isShowing(), even if we are currently assuming
> that an active Panels is always showing.

Done.

[pedro (no code reviews), 2015-11-05 00:39:14]

lgtm

[mdjones, 2015-11-11 01:01:38]

The CQ bit was checked by mdjones@chromium.org

[mdjones, 2015-11-11 01:01:38]

The patchset sent to the CQ was uploaded after l-g-t-m from
dtrainor@chromium.org, pedrosimonetti@chromium.org
Link to the patchset: https://codereview.chromium.org/1432613002/#ps80001
(title: "rebase")

[commit-bot: I haz the power, 2015-11-11 01:05:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1432613002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1432613002/80001

[commit-bot: I haz the power, 2015-11-11 01:52:06]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-11-11 01:52:53]

Patchset 5 (id:??) landed as
https://crrev.com/4a29955fa85fd11c11e311c33173c89a58fe27b7
Cr-Commit-Position: refs/heads/master@{#359015}