Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1890)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanel.java

Issue 1432613002: Generalize ContextualSearchEdgeSwipeHandler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@panel-manager
Patch Set: rebase Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanel.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanel.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanel.java b/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanel.java
index af00630cde264f76a84c3bf465a4f2c344d218ed..ccdfd21677f997ca276800fb31ef53c57d9ffd96 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanel.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanel.java
@@ -394,6 +394,16 @@ public class OverlayPanel extends ContextualSearchPanelAnimation
public void updateSceneLayer(ResourceManager resourceManager) {
}
+ /**
+ * Determine if using a second layout for showing the overlay panel is possible. This should
+ * be overridden by each panel and returns true by default.
+ * @return True if the layout is supported.
+ * TODO(mdjones): Rename to supportsOverlayPanelLayout once the corresponding class is renamed.
+ */
+ public boolean supportsContextualSearchLayout() {
+ return true;
+ }
+
// ============================================================================================
// Generic Event Handling
// ============================================================================================
@@ -489,6 +499,15 @@ public class OverlayPanel extends ContextualSearchPanelAnimation
return false;
}
+ /**
+ * If the panel is intercepting the initial bar swipe event. This should be overridden per
+ * panel.
+ * @return True if the panel intercepted the initial bar swipe.
+ */
+ public boolean onInterceptBarSwipe() {
+ return false;
+ }
+
// ============================================================================================
// Gesture Event helpers
// ============================================================================================
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanel.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698