GN: Avoid nontrivial shell commands in gcc_toolchain tool("link")

remoting/webapp/build_template.gni

Index: remoting/webapp/build_template.gni
diff --git a/remoting/webapp/build_template.gni b/remoting/webapp/build_template.gni
index 3b8d9509f2ccb89951fc5f2f8caa3114315cec46..4216095287fbb10c8358d8e8bb45c32996fcb6cc 100644
--- a/remoting/webapp/build_template.gni
+++ b/remoting/webapp/build_template.gni
@@ -203,7 +203,8 @@ template("desktop_remoting_webapp") {
 
       extra_files += [ "$pexe_dir/remoting_client_plugin_newlib.pexe" ]
       if (is_debug) {
-        extra_files += [ "$pexe_dir/remoting_client_plugin_newlib.pexe.debug" ]
+        extra_files +=
+            [ "$pexe_dir/exe.unstripped/remoting_client_plugin_newlib.pexe" ]

[Sergey Ulanov, 2015/11/04 07:36:23]

The build-webapp.py just copies all files into the target directory. There is
also .nmf file that expects that the debug version has .pexe.debug suffix. So if
the file name is the same this is not going to produce correct build because
.debug file will replace non-debug one. Can we have .pexe.debug extension in the
exe.unstripped directory? Otherwise you either need to modify build-webapp.py to
rename the file (and specify that in the arguments) or add a copy action here to
copy the file to give it .pexe.debug name.

[Roland McGrath, 2015/11/04 20:26:47]

I think it's best that the toolchain rule use the exe.unstripped subdirectory
rather than the .debug suffix, because that makes it consistent with the other
GN toolchains.

It's probably best to use a copy rule for what build-webapp.py expects, because
that will make it consistent with the GYP build.  I'll take a crack at that.

Can you give me a direct pointer to a bot or a local testing command that will
verify that I haven't broken this part of the build?


Thanks,
Roland

       }
     }