GN: Avoid nontrivial shell commands in gcc_toolchain tool("link")

remoting/webapp/build_template.gni

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # Keep in sync with 'remoting_webapp' target in remoting/remoting_client.gypi.
 
 import("//build/config/chrome_build.gni")
 import("//build/config/features.gni")
 import("//build/util/version.gni")
 import("//remoting/remoting_locales.gni")
@@ skipping 185 matching lines @@
       "$target_gen_dir/credits.html",
     ]
 
     if (enable_pnacl) {
       pexe_dir = get_label_info(
               "//remoting/client/plugin:remoting_client_plugin_newlib(//build/toolchain/nacl:newlib_pnacl)",
               "root_out_dir")
 
       extra_files += [ "$pexe_dir/remoting_client_plugin_newlib.pexe" ]
       if (is_debug) {
-        extra_files += [ "$pexe_dir/remoting_client_plugin_newlib.pexe.debug" ]
+        extra_files +=
+            [ "$pexe_dir/exe.unstripped/remoting_client_plugin_newlib.pexe" ]

[Sergey Ulanov, 2015/11/04 07:36:23]

The build-webapp.py just copies all files into the target directory. There is
also .nmf file that expects that the debug version has .pexe.debug suffix. So if
the file name is the same this is not going to produce correct build because
.debug file will replace non-debug one. Can we have .pexe.debug extension in the
exe.unstripped directory? Otherwise you either need to modify build-webapp.py to
rename the file (and specify that in the arguments) or add a copy action here to
copy the file to give it .pexe.debug name.

[Roland McGrath, 2015/11/04 20:26:47]

I think it's best that the toolchain rule use the exe.unstripped subdirectory
rather than the .debug suffix, because that makes it consistent with the other
GN toolchains.

It's probably best to use a copy rule for what build-webapp.py expects, because
that will make it consistent with the GYP build.  I'll take a crack at that.

Can you give me a direct pointer to a bot or a local testing command that will
verify that I haven't broken this part of the build?


Thanks,
Roland

       }
     }
 
     inputs = [ rebase_path("crd/manifest.json.jinja2", root_build_dir) ] +
              remoting_version_files +
              rebase_path(remoting_webapp_crd_files, root_build_dir) +
              extra_files + dr_generated_html_files
 
     outputs = [
       zip_path,
@@ skipping 321 matching lines @@
     args += [
       "--files_listfile",
       rebase_path(file_list, root_build_dir),
     ]
     args += [
       "--locales_listfile",
       rebase_path(locales_listfile_output, root_build_dir),
     ]
   }
 }