Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1065)

Unified Diff: content/common/navigation_params.h

Issue 1432583002: Move browser_navigation_start to CommonNavigationParams (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Simplify changed tests Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/common/navigation_params.h
diff --git a/content/common/navigation_params.h b/content/common/navigation_params.h
index cf3d89a2cbb2fb9473b23918cecb02e030a3d161..351b74723f39d184e48399e9941f3f5dfd2f7e09 100644
--- a/content/common/navigation_params.h
+++ b/content/common/navigation_params.h
@@ -60,7 +60,8 @@ struct CONTENT_EXPORT CommonNavigationParams {
FrameMsg_UILoadMetricsReportType::Value report_type,
const GURL& base_url_for_data_url,
const GURL& history_url_for_data_url,
- LoFiState lofi_state);
+ LoFiState lofi_state,
+ const base::TimeTicks& navigation_start);
~CommonNavigationParams();
// The URL to navigate to.
@@ -107,6 +108,13 @@ struct CONTENT_EXPORT CommonNavigationParams {
// Whether or not to request a LoFi version of the document or let the browser
// decide.
LoFiState lofi_state;
+
+ // The navigationStart time exposed through the Navigation Timing API to JS.
+ // If this is a browser-initiated navigation, this can override the
nasko 2015/11/04 18:39:47 nit: "If this is for a browser-initiated ..."
Charlie Harrison 2015/11/04 21:27:43 Done.
+ // navigation_start value in Blink.
+ // PlzNavigate: For renderer initiated navigations, this will be set on the
+ // renderer side and sent with BeginNavigation.
nasko 2015/11/04 18:39:47 s/BeginNavigation/FrameHostMsg_BeginNavigation/
Charlie Harrison 2015/11/04 21:27:43 Done.
+ base::TimeTicks navigation_start;
};
// Provided by the renderer ----------------------------------------------------
@@ -204,7 +212,6 @@ struct CONTENT_EXPORT StartNavigationParams {
struct CONTENT_EXPORT RequestNavigationParams {
RequestNavigationParams();
RequestNavigationParams(bool is_overriding_user_agent,
- base::TimeTicks navigation_start,
const std::vector<GURL>& redirects,
bool can_load_local_resources,
base::Time request_time,
@@ -223,9 +230,6 @@ struct CONTENT_EXPORT RequestNavigationParams {
// Whether or not the user agent override string should be used.
bool is_overriding_user_agent;
- // The navigationStart time to expose through the Navigation Timing API to JS.
- base::TimeTicks browser_navigation_start;
-
// Any redirect URLs that occurred before |url|. Useful for cross-process
// navigations; defaults to empty.
std::vector<GURL> redirects;

Powered by Google App Engine
This is Rietveld 408576698