Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Unified Diff: content/browser/frame_host/render_frame_host_impl.cc

Issue 1432583002: Move browser_navigation_start to CommonNavigationParams (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Simplify changed tests Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/render_frame_host_impl.cc
diff --git a/content/browser/frame_host/render_frame_host_impl.cc b/content/browser/frame_host/render_frame_host_impl.cc
index 66e303c7014acdd52679293465db1cf9609912df..68870b21aaa5e201efb1d24710f56c8bd571b367 100644
--- a/content/browser/frame_host/render_frame_host_impl.cc
+++ b/content/browser/frame_host/render_frame_host_impl.cc
@@ -1769,8 +1769,8 @@ void RenderFrameHostImpl::NavigateToInterstitialURL(const GURL& data_url) {
CommonNavigationParams common_params(
data_url, Referrer(), ui::PAGE_TRANSITION_LINK,
FrameMsg_Navigate_Type::NORMAL, false, false, base::TimeTicks::Now(),
- FrameMsg_UILoadMetricsReportType::NO_REPORT, GURL(), GURL(),
- LOFI_OFF);
+ FrameMsg_UILoadMetricsReportType::NO_REPORT, GURL(), GURL(), LOFI_OFF,
+ base::TimeTicks::Now());
if (base::CommandLine::ForCurrentProcess()->HasSwitch(
switches::kEnableBrowserSideNavigation)) {
CommitNavigation(nullptr, nullptr, common_params,
@@ -2152,8 +2152,10 @@ void RenderFrameHostImpl::SetNavigationsSuspended(
SetState(RenderFrameHostImpl::STATE_DEFAULT);
DCHECK(!proceed_time.is_null());
- suspended_nav_params_->request_params.browser_navigation_start =
- proceed_time;
+ // TODO(csharrison) make sure that PlzNavigate and the current architecture
nasko 2015/11/04 18:39:47 nit: Missing ":" after todo.
Charlie Harrison 2015/11/04 21:27:43 Done.
+ // measure navigation start in the same way in the presence of the
+ // BeforeUnload event.
+ suspended_nav_params_->common_params.navigation_start = proceed_time;
SendNavigateMessage(suspended_nav_params_->common_params,
suspended_nav_params_->start_params,
suspended_nav_params_->request_params);

Powered by Google App Engine
This is Rietveld 408576698