content/browser/frame_host/navigator_impl.cc - Issue 1432583002: Move browser_navigation_start to CommonNavigationParams

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/navigator_impl.cc

Issue 1432583002: Move browser_navigation_start to CommonNavigationParams (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Simplify changed tests Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/frame_host/navigation_request.cc ('k') | content/browser/frame_host/render_frame_host_impl.cc » ('j') | content/browser/frame_host/render_frame_host_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/navigator_impl.cc

diff --git a/content/browser/frame_host/navigator_impl.cc b/content/browser/frame_host/navigator_impl.cc

index 5d9f22528208fe1beaa2dd7ec1b3c455b248e52c..788c23d356b18b45d4df4d95cec5b5bfa4f5ae1a 100644

--- a/content/browser/frame_host/navigator_impl.cc

+++ b/content/browser/frame_host/navigator_impl.cc

@@ -341,11 +341,12 @@ bool NavigatorImpl::NavigateToEntry(

? LOFI_OFF

: LOFI_UNSPECIFIED);

dest_render_frame_host->Navigate(

- entry.ConstructCommonNavigationParams(

- dest_url, dest_referrer, frame_entry, navigation_type, lofi_state),

+ entry.ConstructCommonNavigationParams(dest_url, dest_referrer,

+ frame_entry, navigation_type,

+ lofi_state, navigation_start),

entry.ConstructStartNavigationParams(),

entry.ConstructRequestNavigationParams(

- frame_entry, navigation_start, is_same_document_history_load,

+ frame_entry, is_same_document_history_load,

frame_tree_node->has_committed_real_load(),

controller_->GetPendingEntryIndex() == -1,

controller_->GetIndexOfEntry(&entry),