Move browser_navigation_start to CommonNavigationParams

Move browser_navigation_start to CommonNavigationParams
This is 1/3 of the effort to add a navigation_start timestamp to DidStartProvisional load. The full CL we're breaking up is here:
https://codereview.chromium.org/1425823002/

BUG=548335
Committed: https://crrev.com/8eb7b818c41323b4621cf4f04a152bd1bee12f98
Cr-Commit-Position: refs/heads/master@{#357914}

[Charlie Harrison, 2015-11-03 16:24:04]

Description was changed from

==========
Move browser_navigation_start to CommonNavigationParams

BUG=548335
==========

to

==========
Move browser_navigation_start to CommonNavigationParams
This is 1/3 of the effort to add a navigation_start timestamp to
DidStartProvisional load. The full CL we're breaking up is here:
https://codereview.chromium.org/1425823002/

BUG=548335
==========

[Charlie Harrison, 2015-11-03 16:54:16]

csharrison@chromium.org changed reviewers:
+ clamy@chromium.org, nasko@chromium.org

[Charlie Harrison, 2015-11-03 16:54:17]

PTAL.
Camille: Let me know if there's anything more you'd like me to do about the
proceed_time stuff besides adding the TODO.

Thanks!

[clamy, 2015-11-04 13:19:50]

Thanks! Lgtm with nits.

https://codereview.chromium.org/1432583002/diff/20001/content/renderer/render...
File content/renderer/render_view_browsertest.cc (right):

https://codereview.chromium.org/1432583002/diff/20001/content/renderer/render...
content/renderer/render_view_browsertest.cc:2275: RequestNavigationParams
early_request_params;
nit: since we're not setting any member in the RequestNavigationParams anymore,
let's not declare them and just call Navigate with RequestNavigationParams().

https://codereview.chromium.org/1432583002/diff/20001/content/renderer/render...
content/renderer/render_view_browsertest.cc:2294: RequestNavigationParams
late_request_params;
Same here.

[Charlie Harrison, 2015-11-04 13:44:57]

On 2015/11/04 13:19:50, clamy wrote:
> Thanks! Lgtm with nits.
> 
>
https://codereview.chromium.org/1432583002/diff/20001/content/renderer/render...
> File content/renderer/render_view_browsertest.cc (right):
> 
>
https://codereview.chromium.org/1432583002/diff/20001/content/renderer/render...
> content/renderer/render_view_browsertest.cc:2275: RequestNavigationParams
> early_request_params;
> nit: since we're not setting any member in the RequestNavigationParams
anymore,
> let's not declare them and just call Navigate with RequestNavigationParams().
> 
>
https://codereview.chromium.org/1432583002/diff/20001/content/renderer/render...
> content/renderer/render_view_browsertest.cc:2294: RequestNavigationParams
> late_request_params;
> Same here.

Done! Thanks!

[nasko, 2015-11-04 18:39:47]

LGTM with a few nits.

https://codereview.chromium.org/1432583002/diff/40001/content/browser/frame_h...
File content/browser/frame_host/render_frame_host_impl.cc (right):

https://codereview.chromium.org/1432583002/diff/40001/content/browser/frame_h...
content/browser/frame_host/render_frame_host_impl.cc:2155: // TODO(csharrison)
make sure that PlzNavigate and the current architecture
nit: Missing ":" after todo.

https://codereview.chromium.org/1432583002/diff/40001/content/common/navigati...
File content/common/navigation_params.h (right):

https://codereview.chromium.org/1432583002/diff/40001/content/common/navigati...
content/common/navigation_params.h:113: // If this is a browser-initiated
navigation, this can override the
nit: "If this is for a browser-initiated ..."

https://codereview.chromium.org/1432583002/diff/40001/content/common/navigati...
content/common/navigation_params.h:116: // renderer side and sent with
BeginNavigation.
s/BeginNavigation/FrameHostMsg_BeginNavigation/

[Charlie Harrison, 2015-11-04 21:27:43]

Thanks!

https://codereview.chromium.org/1432583002/diff/40001/content/browser/frame_h...
File content/browser/frame_host/render_frame_host_impl.cc (right):

https://codereview.chromium.org/1432583002/diff/40001/content/browser/frame_h...
content/browser/frame_host/render_frame_host_impl.cc:2155: // TODO(csharrison)
make sure that PlzNavigate and the current architecture
On 2015/11/04 18:39:47, nasko (slow to review) wrote:
> nit: Missing ":" after todo.

Done.

https://codereview.chromium.org/1432583002/diff/40001/content/common/navigati...
File content/common/navigation_params.h (right):

https://codereview.chromium.org/1432583002/diff/40001/content/common/navigati...
content/common/navigation_params.h:113: // If this is a browser-initiated
navigation, this can override the
On 2015/11/04 18:39:47, nasko (slow to review) wrote:
> nit: "If this is for a browser-initiated ..."

Done.

https://codereview.chromium.org/1432583002/diff/40001/content/common/navigati...
content/common/navigation_params.h:116: // renderer side and sent with
BeginNavigation.
On 2015/11/04 18:39:47, nasko (slow to review) wrote:
> s/BeginNavigation/FrameHostMsg_BeginNavigation/

Done.

[Charlie Harrison, 2015-11-04 21:28:44]

The CQ bit was checked by csharrison@chromium.org

[Charlie Harrison, 2015-11-04 21:28:44]

The patchset sent to the CQ was uploaded after l-g-t-m from clamy@chromium.org,
nasko@chromium.org
Link to the patchset: https://codereview.chromium.org/1432583002/#ps60001
(title: "Nasko review")

[commit-bot: I haz the power, 2015-11-04 21:28:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1432583002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1432583002/60001

[commit-bot: I haz the power, 2015-11-04 22:36:49]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-11-04 22:37:58]

Patchset 4 (id:??) landed as
https://crrev.com/8eb7b818c41323b4621cf4f04a152bd1bee12f98
Cr-Commit-Position: refs/heads/master@{#357914}