Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(715)

Unified Diff: content/browser/frame_host/navigation_request.cc

Issue 1432583002: Move browser_navigation_start to CommonNavigationParams (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Nasko review Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/frame_host/navigation_request.h ('k') | content/browser/frame_host/navigator_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/frame_host/navigation_request.cc
diff --git a/content/browser/frame_host/navigation_request.cc b/content/browser/frame_host/navigation_request.cc
index 93d9887eed0109858c360b3ac98c8b1f21d3dc7d..f95e944a42595f2c9018bec236c12f3d1010e90f 100644
--- a/content/browser/frame_host/navigation_request.cc
+++ b/content/browser/frame_host/navigation_request.cc
@@ -62,7 +62,7 @@ scoped_ptr<NavigationRequest> NavigationRequest::CreateBrowserInitiated(
const NavigationEntryImpl& entry,
FrameMsg_Navigate_Type::Value navigation_type,
bool is_same_document_history_load,
- base::TimeTicks navigation_start,
+ const base::TimeTicks& navigation_start,
NavigationControllerImpl* controller) {
std::string method = entry.GetHasPostData() ? "POST" : "GET";
@@ -89,14 +89,14 @@ scoped_ptr<NavigationRequest> NavigationRequest::CreateBrowserInitiated(
frame_tree_node,
entry.ConstructCommonNavigationParams(dest_url, dest_referrer,
frame_entry, navigation_type,
- LOFI_UNSPECIFIED),
+ LOFI_UNSPECIFIED, navigation_start),
BeginNavigationParams(method, headers.ToString(),
LoadFlagFromNavigationType(navigation_type),
false, // has_user_gestures
false, // skip_service_worker
REQUEST_CONTEXT_TYPE_LOCATION),
entry.ConstructRequestNavigationParams(
- frame_entry, navigation_start, is_same_document_history_load,
+ frame_entry, is_same_document_history_load,
frame_tree_node->has_committed_real_load(),
controller->GetPendingEntryIndex() == -1,
controller->GetIndexOfEntry(&entry),
@@ -123,7 +123,6 @@ scoped_ptr<NavigationRequest> NavigationRequest::CreateRendererInitiated(
// TODO(clamy): Set has_committed_real_load.
RequestNavigationParams request_params(
false, // is_overriding_user_agent
- base::TimeTicks::Now(), // browser_navigation_start
std::vector<GURL>(), // redirects
false, // can_load_local_resources
base::Time::Now(), // request_time
« no previous file with comments | « content/browser/frame_host/navigation_request.h ('k') | content/browser/frame_host/navigator_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698