Enable 'Browsing data volume counters on Desktop' by default.

chrome/browser/about_flags.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/about_flags.h"
 
 #include <iterator>
 #include <map>
 #include <set>
 #include <utility>
@@ skipping 1986 matching lines @@
     {"enable-tab-discarding",
      IDS_FLAGS_ENABLE_TAB_DISCARDING_NAME,
      IDS_FLAGS_ENABLE_TAB_DISCARDING_DESCRIPTION,
      kOsWin | kOsMac,
      SINGLE_VALUE_TYPE(switches::kEnableTabDiscarding)},
 #endif
     {"enable-clear-browsing-data-counters",
      IDS_FLAGS_ENABLE_CLEAR_BROWSING_DATA_COUNTERS_NAME,
      IDS_FLAGS_ENABLE_CLEAR_BROWSING_DATA_COUNTERS_DESCRIPTION,
      kOsAll,
-     SINGLE_VALUE_TYPE(switches::kEnableClearBrowsingDataCounters)
+     ENABLE_DISABLE_VALUE_TYPE(switches::kEnableClearBrowsingDataCounters,
+                               switches::kDisableClearBrowsingDataCounters)

[Peter Mayo, 2015/11/09 21:46:29]

This includes OS_CHROMEOS.

It doesn't seem like the tests stay happy when it does.
Please fix the code or tests appropriately.

[msramek, 2015/11/09 22:48:04]

Hm, I see the problem in HistoryCounter. It's not caused by this CL, but it is
exposed by it. I'll fix it tomorrow and reland this. Sorry for the trouble!

     },
 #if defined(ENABLE_TASK_MANAGER)
     {"disable-new-task-manager",
      IDS_FLAGS_DISABLE_NEW_TASK_MANAGER_NAME,
      IDS_FLAGS_DISABLE_NEW_TASK_MANAGER_DESCRIPTION,
      kOsDesktop,
      SINGLE_VALUE_TYPE(switches::kDisableNewTaskManager)
     },
 #endif  // defined(ENABLE_TASK_MANAGER)
     {"simplified-fullscreen-ui",
@@ skipping 946 matching lines @@
   FlagsState::GetInstance()->SetFeatureEntries(entries, count);
 }
 
 const FeatureEntry* GetFeatureEntries(size_t* count) {
   return FlagsState::GetInstance()->GetFeatureEntries(count);
 }
 
 }  // namespace testing
 
 }  // namespace about_flags