Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 1432553003: Revert of Reland Reland Switch Chrome Android using v8 arch specific external data name (Closed)

Created:
5 years, 1 month ago by Sam McNally
Modified:
5 years, 1 month ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, cbentzel+watch_chromium.org, mkwst+moarreviews-shell_chromium.org, lcwu+watch_chromium.org, jam, darin-cc_chromium.org, mikecase+watch_chromium.org, halliwell+watch_chromium.org, blink-reviews, gunsch+watch_chromium.org, klundberg+watch_chromium.org, jbudorick+watch_chromium.org, jochen+watch_chromium.org, yfriedman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Reland Reland Switch Chrome Android using v8 arch specific external data name (patchset #9 id:180001 of https://codereview.chromium.org/1422793004/ ) Reason for revert: Looks like it caused Android GN net_unittests to crash: https://build.chromium.org/p/chromium.linux/builders/Android%20GN/builds/31886/steps/net_unittests/logs/stdio; suspect it's crashing a ProxyResolverV8 test. Original issue's description: > Reland Reland Switch Chrome Android using v8 arch specific external data name > > This patch also fix package_resource.py issue that asset's > renaming didn't trigger the packaging. > > origin patch > https://codereview.chromium.org/1417753004/ > > Switch Chrome Android using v8 arch specific external data name > > For 32-bit, natives_blob_32.bin and snapshot_blob_32.bin are used. > For 64-bit, natives_blob_64.bin and natives_blob_64.bin are used. > > This patch also removed the existing v8 startup data in > destination directory by using copy_ex to remove directory > first. > > BUG=540788, 547235 > > TBR=jochen@chromium.org,dpranke@chromium.org,halliwell@chromium.org,jbudorick@chromium.org,mef@chromium.org,rmcilroy@chromium.org,dtrainor@chromium.org,cpu@chromium.org > > Committed: https://crrev.com/02d6496adfb377afc0708e53cd0c8118c0591f99 > Cr-Commit-Position: refs/heads/master@{#357480} TBR=jbudorick@chromium.org,miguelg@chromium.org,michaelbai@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=540788, 547235 Committed: https://crrev.com/fdd09962365511096c8f8c4ec388254325aa90e6 Cr-Commit-Position: refs/heads/master@{#357523}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -171 lines) Patch
M base/android/java/src/org/chromium/base/ApkAssets.java View 1 chunk +13 lines, -0 lines 0 comments Download
M build/android/gyp/package_resources.py View 1 chunk +2 lines, -13 lines 0 comments Download
D build/android/v8_external_startup_data_arch_suffix.gypi View 1 chunk +0 lines, -21 lines 0 comments Download
M build_overrides/v8.gni View 1 chunk +0 lines, -18 lines 0 comments Download
M chrome/android/BUILD.gn View 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/chrome_android_paks.gypi View 3 chunks +6 lines, -15 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 2 chunks +4 lines, -11 lines 0 comments Download
M chromecast/chromecast.gyp View 3 chunks +2 lines, -9 lines 0 comments Download
M components/components_tests.gyp View 3 chunks +8 lines, -15 lines 0 comments Download
M components/html_viewer/BUILD.gn View 1 chunk +3 lines, -3 lines 0 comments Download
M content/content.gyp View 2 chunks +1 line, -6 lines 0 comments Download
M content/content_shell.gypi View 1 chunk +3 lines, -6 lines 0 comments Download
M content/content_tests.gypi View 2 chunks +4 lines, -11 lines 0 comments Download
M content/shell/android/BUILD.gn View 1 chunk +4 lines, -2 lines 0 comments Download
M gin/v8_initializer.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M net/net.gyp View 2 chunks +4 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/platform/blink_platform_tests.gyp View 2 chunks +4 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/web/web_tests.gyp View 1 chunk +3 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Sam McNally
Created Revert of Reland Reland Switch Chrome Android using v8 arch specific external data name
5 years, 1 month ago (2015-11-03 03:29:18 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1432553003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1432553003/1
5 years, 1 month ago (2015-11-03 03:29:52 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-03 03:31:10 UTC) #3
commit-bot: I haz the power
5 years, 1 month ago (2015-11-03 03:31:57 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fdd09962365511096c8f8c4ec388254325aa90e6
Cr-Commit-Position: refs/heads/master@{#357523}

Powered by Google App Engine
This is Rietveld 408576698