Issue 1432513002: Merge to XFA: Add a test for the HexDecode method.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1432513002: Merge to XFA: Add a test for the HexDecode method. (Closed)

Created:
5 years, 1 month ago by dsinclair

Modified:
5 years, 1 month ago

Reviewers:
Tom Sepez

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa

Target Ref:
refs/heads/xfa

Visibility:
Public.

Merge to XFA: Add a test for the HexDecode method. I moved the declaration to be public, instead of having it implicit in one file and defined in a seperate cpp file. TBR=tsepez@chromium.org Review URL: https://codereview.chromium.org/1410873009 . (cherry picked from commit e948a4ee08b78e27da37bc12244fa1b66d927dc7) Committed: https://pdfium.googlesource.com/pdfium/+/4d6f03a5aa4053640066e829a7450c3177cb2770

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+85 lines, -27 lines)			Patch
M	BUILD.gn	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	core/include/fpdfapi/fpdf_parser.h	View	1 chunk	+18 lines, -0 lines	0 comments	Download
M	core/src/fpdfapi/fpdf_page/fpdf_page_parser_old.cpp	View	2 chunks	+3 lines, -17 lines	0 comments	Download
M	core/src/fpdfapi/fpdf_parser/fpdf_parser_decode.cpp	View	3 chunks	+10 lines, -10 lines	0 comments	Download
A	core/src/fpdfapi/fpdf_parser/fpdf_parser_decode_unittest.cpp	View	1 chunk	+52 lines, -0 lines	0 comments	Download
M	pdfium.gyp	View	1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 2 (0 generated)

dsinclair

5 years, 1 month ago (2015-11-02 21:12:45 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
4d6f03a5aa4053640066e829a7450c3177cb2770 (presubmit successful).