Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 1410873009: Add a test for the HexDecode method. (Closed)

Created:
5 years, 1 month ago by dsinclair
Modified:
5 years, 1 month ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add a test for the HexDecode method. I moved the declaration to be public, instead of having it implicit in one file and defined in a seperate cpp file. R=tsepez@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/e948a4ee08b78e27da37bc12244fa1b66d927dc7

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -27 lines) Patch
M BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M core/include/fpdfapi/fpdf_parser.h View 1 1 chunk +18 lines, -0 lines 0 comments Download
M core/src/fpdfapi/fpdf_page/fpdf_page_parser_old.cpp View 2 chunks +3 lines, -17 lines 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_decode.cpp View 3 chunks +10 lines, -10 lines 0 comments Download
A core/src/fpdfapi/fpdf_parser/fpdf_parser_decode_unittest.cpp View 1 chunk +52 lines, -0 lines 0 comments Download
M pdfium.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
dsinclair
PTAL.
5 years, 1 month ago (2015-11-02 20:34:23 UTC) #3
Tom Sepez
Okay, we keep moving these back and forth. Fine to make them public for testing. ...
5 years, 1 month ago (2015-11-02 20:46:37 UTC) #4
dsinclair
On 2015/11/02 20:46:37, Tom Sepez wrote: > Okay, we keep moving these back and forth. ...
5 years, 1 month ago (2015-11-02 20:58:47 UTC) #5
dsinclair
5 years, 1 month ago (2015-11-02 20:58:59 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
e948a4ee08b78e27da37bc12244fa1b66d927dc7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698