Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1432503003: Comments Style: s/skbug.com/bug.skia.org/ (Closed)

Created:
5 years, 1 month ago by hal.canary
Modified:
5 years, 1 month ago
Reviewers:
jcgregorio
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : include #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -64 lines) Patch
M DEPS View 1 1 chunk +1 line, -1 line 0 comments Download
M PRESUBMIT.py View 2 chunks +2 lines, -2 lines 0 comments Download
M bench/nanobench.cpp View 1 3 chunks +3 lines, -3 lines 0 comments Download
M dm/DM.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M gm/aaclip.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/cubicpaths.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/draw_bitmap_rect_skbug4374.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/imagefilters.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/roundrects.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gyp/common_conditions.gypi View 2 chunks +3 lines, -3 lines 0 comments Download
M gyp/libwebp_skia.gypi View 1 chunk +1 line, -1 line 0 comments Download
M gyp/skia_for_android_framework_defines.gypi View 1 chunk +1 line, -1 line 0 comments Download
M site/dev/design/pdftheory.md View 3 chunks +9 lines, -9 lines 0 comments Download
M src/codec/SkCodec_libpng.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkConvolver.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkImageCacherator.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkImageGenerator.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkRRect.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrBufferAllocPool.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrClipMaskManager.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrResourceProvider.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/GrResourceProvider.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrConvexPolyEffect.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGLCaps.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M src/pdf/SkPDFDevice.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M src/ports/SkFontMgr_fontconfig.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/CodexTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/ImageDecodingTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/ImageTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/PathTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/ReadPixelsTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/RecordDrawTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/SkResourceCacheTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/libwebp/webp/config.h View 1 chunk +1 line, -1 line 0 comments Download
M tools/nanobench_flags.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/skpdiff/SkDiffContext.h View 1 chunk +1 line, -1 line 0 comments Download
M tools/skpdiff/SkDiffContext.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M tools/skpdiff/SkImageDiffer.h View 1 chunk +1 line, -1 line 0 comments Download
M tools/skpdiff/skpdiff_main.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (5 generated)
hal.canary
PTAL
5 years, 1 month ago (2015-11-06 20:08:44 UTC) #2
mtklein
On 2015/11/06 at 20:08:44, halcanary wrote: > PTAL skbug.com is shorter than bug.skia.org. Just sayin'.
5 years, 1 month ago (2015-11-06 20:11:33 UTC) #3
hal.canary
On 2015/11/06 at 20:11:33, mtklein wrote: > On 2015/11/06 at 20:08:44, halcanary wrote: > > ...
5 years, 1 month ago (2015-11-06 20:15:43 UTC) #4
jcgregorio
lgtm
5 years, 1 month ago (2015-11-06 20:45:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1432503003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1432503003/1
5 years, 1 month ago (2015-11-06 22:13:23 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/builds/3735)
5 years, 1 month ago (2015-11-06 22:14:42 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1432503003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1432503003/20001
5 years, 1 month ago (2015-11-07 13:17:30 UTC) #12
commit-bot: I haz the power
5 years, 1 month ago (2015-11-07 13:29:06 UTC) #13
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/6950de6c4166fabb35e6c756fc009e0cf1c47819

Powered by Google App Engine
This is Rietveld 408576698