Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 1432453002: Merge to XFA: linux: Remove unneeded -L flags from static library targets. (Closed)

Created:
5 years, 1 month ago by Lei Zhang
Modified:
5 years, 1 month ago
Reviewers:
Nico
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Merge to XFA: linux: Remove unneeded -L flags from static library targets. -L isn't used for creating static libraries. This flag isn't present on non-Linux or in the gn file either. TBR=thakis@chromium.org Review URL: https://codereview.chromium.org/1425213003 . (cherry picked from commit b0337e68fb84c807e0d898aecaad0074444d62e0) Committed: https://pdfium.googlesource.com/pdfium/+/80e039bfc4108591c9783ab531b916ab98a8414c

Patch Set 1 #

Patch Set 2 : XFA #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -15 lines) Patch
M pdfium.gyp View 1 13 chunks +0 lines, -15 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Lei Zhang
TBR, and did the same for XFA.
5 years, 1 month ago (2015-10-30 21:57:39 UTC) #1
Lei Zhang
Committed patchset #2 (id:20001) manually as 80e039bfc4108591c9783ab531b916ab98a8414c (presubmit successful).
5 years, 1 month ago (2015-10-30 21:58:11 UTC) #2
Nico
5 years, 1 month ago (2015-10-30 22:11:07 UTC) #3
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698