Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Issue 1425213003: linux: Remove -L flags from static library targets. (Closed)

Created:
5 years, 1 month ago by Nico
Modified:
5 years, 1 month ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

linux: Remove unneeded -L flags from static library targets. -L isn't used for creating static libraries. This flag isn't present on non-Linux or in the gn file either. BUG=none R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/b0337e68fb84c807e0d898aecaad0074444d62e0

Patch Set 1 #

Total comments: 1

Patch Set 2 : fix, rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -14 lines) Patch
M pdfium.gyp View 1 12 chunks +0 lines, -14 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Nico
(i haven't actually tested this)
5 years, 1 month ago (2015-10-30 16:47:23 UTC) #2
Lei Zhang
https://codereview.chromium.org/1425213003/diff/1/pdfium.gyp File pdfium.gyp (right): https://codereview.chromium.org/1425213003/diff/1/pdfium.gyp#newcode443 pdfium.gyp:443: '-L<(PRODUCT_DIR)', test fails here
5 years, 1 month ago (2015-10-30 17:17:22 UTC) #3
Lei Zhang
On 2015/10/30 17:17:22, Lei Zhang wrote: > https://codereview.chromium.org/1425213003/diff/1/pdfium.gyp > File pdfium.gyp (right): > > https://codereview.chromium.org/1425213003/diff/1/pdfium.gyp#newcode443 ...
5 years, 1 month ago (2015-10-30 17:26:12 UTC) #4
Nico
5 years, 1 month ago (2015-10-30 17:37:25 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
b0337e68fb84c807e0d898aecaad0074444d62e0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698