Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Unified Diff: pkg/analysis_server/lib/src/operation/operation_analysis.dart

Issue 1432423004: Send any logError() information to the IDE. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Add messages for all sendServerErrorNotification() invocations. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analysis_server/lib/src/domain_completion.dart ('k') | pkg/analysis_server/lib/src/server/driver.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/lib/src/operation/operation_analysis.dart
diff --git a/pkg/analysis_server/lib/src/operation/operation_analysis.dart b/pkg/analysis_server/lib/src/operation/operation_analysis.dart
index 1e430d500850906c5e4bc6b21a21e0c68c97cfed..aeb8d039482244714822f9f90b4637bf65a41eb4 100644
--- a/pkg/analysis_server/lib/src/operation/operation_analysis.dart
+++ b/pkg/analysis_server/lib/src/operation/operation_analysis.dart
@@ -276,7 +276,8 @@ void _sendNotification(AnalysisServer server, f()) {
try {
f();
} catch (exception, stackTrace) {
- server.sendServerErrorNotification(exception, stackTrace);
+ server.sendServerErrorNotification(
+ 'Failed to send notification', exception, stackTrace);
}
});
}
@@ -418,7 +419,8 @@ class PerformAnalysisOperation extends ServerOperation {
scheduleIndexOperation(server, file, dartUnit);
}
} catch (exception, stackTrace) {
- server.sendServerErrorNotification(exception, stackTrace);
+ server.sendServerErrorNotification(
+ 'Failed to index Dart file: $file', exception, stackTrace);
}
// HTML
try {
@@ -427,7 +429,8 @@ class PerformAnalysisOperation extends ServerOperation {
server.addOperation(new _HtmlIndexOperation(context, file, htmlUnit));
}
} catch (exception, stackTrace) {
- server.sendServerErrorNotification(exception, stackTrace);
+ server.sendServerErrorNotification(
+ 'Failed to index HTML file: $file', exception, stackTrace);
}
}
}
@@ -463,7 +466,8 @@ class _DartIndexOperation extends _SingleFileOperation {
AnalysisContext context = unit.element.context;
index.index(context, unit);
} catch (exception, stackTrace) {
- server.sendServerErrorNotification(exception, stackTrace);
+ server.sendServerErrorNotification(
+ 'Failed to index: $file', exception, stackTrace);
}
});
}
« no previous file with comments | « pkg/analysis_server/lib/src/domain_completion.dart ('k') | pkg/analysis_server/lib/src/server/driver.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698