Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 1432423003: Fix ~ operator in asm typer, add more operator tests. (Closed)

Created:
5 years, 1 month ago by bradn
Modified:
5 years, 1 month ago
Reviewers:
titzer, aseemgarg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix ~ operator in asm typer, add more operator tests. The ~ operator is de-sugared into true^x, which was being improperly handled. Adding tests of most bitwise operators and several error cases. BUG= https://code.google.com/p/v8/issues/detail?id=4203 TEST=test-asm-validator R=titzer@chromium.org,aseemgarg@chromium.org LOG=N Committed: https://crrev.com/ab1165fb1af936306d238d082815895f91faed97 Cr-Commit-Position: refs/heads/master@{#31951}

Patch Set 1 #

Patch Set 2 : fix gcc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+223 lines, -1 line) Patch
M src/typing-asm.cc View 3 chunks +19 lines, -1 line 0 comments Download
M test/cctest/test-asm-validator.cc View 1 2 chunks +204 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
bradn
5 years, 1 month ago (2015-11-11 21:45:39 UTC) #1
titzer
lgtm
5 years, 1 month ago (2015-11-11 22:09:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1432423003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1432423003/1
5 years, 1 month ago (2015-11-11 22:13:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1432423003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1432423003/20001
5 years, 1 month ago (2015-11-11 22:16:07 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-11 22:34:17 UTC) #9
commit-bot: I haz the power
5 years, 1 month ago (2015-11-14 23:20:22 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ab1165fb1af936306d238d082815895f91faed97
Cr-Commit-Position: refs/heads/master@{#31951}

Powered by Google App Engine
This is Rietveld 408576698