Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: test/cctest/test-asm-validator.cc

Issue 1432423003: Fix ~ operator in asm typer, add more operator tests. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: fix gcc Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/typing-asm.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/test-asm-validator.cc
diff --git a/test/cctest/test-asm-validator.cc b/test/cctest/test-asm-validator.cc
index 8923e21e9ffb69e8b6dfe78a3e10018ad6c68180..7ef67aa15241518b7ec95cfde51f9f6e71dc3aed 100644
--- a/test/cctest/test-asm-validator.cc
+++ b/test/cctest/test-asm-validator.cc
@@ -653,6 +653,154 @@ TEST(Addition2) {
}
+#define TEST_COMPARE_OP(name, op) \
+ TEST(name) { \
+ CHECK_FUNC_TYPES_BEGIN("function bar() { return (0 " op \
+ " 0)|0; }\n" \
+ "function foo() { bar(); }") { \
+ CHECK_EXPR(FunctionLiteral, FUNC_I_TYPE) { \
+ CHECK_EXPR(BinaryOperation, Bounds(cache.kInt32)) { \
+ CHECK_EXPR(CompareOperation, Bounds(cache.kInt32)) { \
+ CHECK_EXPR(Literal, Bounds(cache.kInt32)); \
+ CHECK_EXPR(Literal, Bounds(cache.kInt32)); \
+ } \
+ CHECK_EXPR(Literal, Bounds(cache.kInt32)); \
+ } \
+ } \
+ CHECK_SKIP(); \
+ } \
+ CHECK_FUNC_TYPES_END \
+ }
+
+
+TEST_COMPARE_OP(EqOperator, "==")
+TEST_COMPARE_OP(LtOperator, "<")
+TEST_COMPARE_OP(LteOperator, "<=")
+TEST_COMPARE_OP(GtOperator, ">")
+TEST_COMPARE_OP(GteOperator, ">=")
+
+
+TEST(NeqOperator) {
+ CHECK_FUNC_TYPES_BEGIN(
+ "function bar() { return (0 != 0)|0; }\n"
+ "function foo() { bar(); }") {
+ CHECK_EXPR(FunctionLiteral, FUNC_I_TYPE) {
+ CHECK_EXPR(BinaryOperation, Bounds(cache.kInt32)) {
+ CHECK_EXPR(UnaryOperation, Bounds(cache.kInt32)) {
+ CHECK_EXPR(CompareOperation, Bounds(cache.kInt32)) {
+ CHECK_EXPR(Literal, Bounds(cache.kInt32));
+ CHECK_EXPR(Literal, Bounds(cache.kInt32));
+ }
+ }
+ CHECK_EXPR(Literal, Bounds(cache.kInt32));
+ }
+ }
+ CHECK_SKIP();
+ }
+ CHECK_FUNC_TYPES_END
+}
+
+
+TEST(NotOperator) {
+ CHECK_FUNC_TYPES_BEGIN(
+ "function bar() { var x = 0; return (!x)|0; }\n"
+ "function foo() { bar(); }") {
+ CHECK_EXPR(FunctionLiteral, FUNC_I_TYPE) {
+ CHECK_EXPR(Assignment, Bounds(cache.kInt32)) {
+ CHECK_VAR(x, Bounds(cache.kInt32));
+ CHECK_EXPR(Literal, Bounds(cache.kInt32));
+ }
+ CHECK_EXPR(BinaryOperation, Bounds(cache.kInt32)) {
+ CHECK_EXPR(UnaryOperation, Bounds(cache.kInt32)) {
+ CHECK_VAR(x, Bounds(cache.kInt32));
+ }
+ CHECK_EXPR(Literal, Bounds(cache.kInt32));
+ }
+ }
+ CHECK_SKIP();
+ }
+ CHECK_FUNC_TYPES_END
+}
+
+
+TEST(InvertOperator) {
+ CHECK_FUNC_TYPES_BEGIN(
+ "function bar() { var x = 0; return (~x)|0; }\n"
+ "function foo() { bar(); }") {
+ CHECK_EXPR(FunctionLiteral, FUNC_I_TYPE) {
+ CHECK_EXPR(Assignment, Bounds(cache.kInt32)) {
+ CHECK_VAR(x, Bounds(cache.kInt32));
+ CHECK_EXPR(Literal, Bounds(cache.kInt32));
+ }
+ CHECK_EXPR(BinaryOperation, Bounds(cache.kInt32)) {
+ CHECK_EXPR(BinaryOperation, Bounds(cache.kInt32)) {
+ CHECK_VAR(x, Bounds(cache.kInt32));
+ CHECK_EXPR(Literal, Bounds(cache.kInt32));
+ }
+ CHECK_EXPR(Literal, Bounds(cache.kInt32));
+ }
+ }
+ CHECK_SKIP();
+ }
+ CHECK_FUNC_TYPES_END
+}
+
+
+TEST(InvertConversion) {
+ CHECK_FUNC_TYPES_BEGIN(
+ "function bar() { var x = 0.0; return (~~x)|0; }\n"
+ "function foo() { bar(); }") {
+ CHECK_EXPR(FunctionLiteral, FUNC_I_TYPE) {
+ CHECK_EXPR(Assignment, Bounds(cache.kFloat64)) {
+ CHECK_VAR(x, Bounds(cache.kFloat64));
+ CHECK_EXPR(Literal, Bounds(cache.kFloat64));
+ }
+ CHECK_EXPR(BinaryOperation, Bounds(cache.kInt32)) {
+ CHECK_EXPR(BinaryOperation, Bounds(cache.kInt32)) {
+ CHECK_EXPR(BinaryOperation, Bounds(cache.kInt32)) {
+ CHECK_VAR(x, Bounds(cache.kFloat64));
+ CHECK_EXPR(Literal, Bounds(cache.kInt32));
+ }
+ CHECK_EXPR(Literal, Bounds(cache.kInt32));
+ }
+ CHECK_EXPR(Literal, Bounds(cache.kInt32));
+ }
+ }
+ CHECK_SKIP();
+ }
+ CHECK_FUNC_TYPES_END
+}
+
+
+#define TEST_INT_BIN_OP(name, op) \
+ TEST(name) { \
+ CHECK_FUNC_TYPES_BEGIN("function bar() { var x = 0; return (x " op \
+ " 123)|0; }\n" \
+ "function foo() { bar(); }") { \
+ CHECK_EXPR(FunctionLiteral, FUNC_I_TYPE) { \
+ CHECK_EXPR(Assignment, Bounds(cache.kInt32)) { \
+ CHECK_VAR(x, Bounds(cache.kInt32)); \
+ CHECK_EXPR(Literal, Bounds(cache.kInt32)); \
+ } \
+ CHECK_EXPR(BinaryOperation, Bounds(cache.kInt32)) { \
+ CHECK_EXPR(BinaryOperation, Bounds(cache.kInt32)) { \
+ CHECK_VAR(x, Bounds(cache.kInt32)); \
+ CHECK_EXPR(Literal, Bounds(cache.kInt32)); \
+ } \
+ CHECK_EXPR(Literal, Bounds(cache.kInt32)); \
+ } \
+ } \
+ CHECK_SKIP(); \
+ } \
+ CHECK_FUNC_TYPES_END \
+ }
+
+
+TEST_INT_BIN_OP(AndOperator, "&")
+TEST_INT_BIN_OP(OrOperator, "|")
+TEST_INT_BIN_OP(XorOperator, "^")
+
+
TEST(UnsignedCompare) {
CHECK_FUNC_TYPES_BEGIN(
"function bar() { var x = 1; var y = 1; return ((x>>>0) < (y>>>0))|0; }\n"
@@ -1127,6 +1275,62 @@ TEST(UnboundVariable) {
}
+TEST(EqStrict) {
+ CHECK_FUNC_ERROR(
+ "function bar() { return (0 === 0)|0; }\n"
+ "function foo() { bar(); }",
+ "asm: line 39: illegal comparison operator\n");
+}
+
+
+TEST(NeStrict) {
+ CHECK_FUNC_ERROR(
+ "function bar() { return (0 !== 0)|0; }\n"
+ "function foo() { bar(); }",
+ "asm: line 39: illegal comparison operator\n");
+}
+
+
+TEST(InstanceOf) {
+ CHECK_FUNC_ERROR(
+ "function bar() { return (0 instanceof 0)|0; }\n"
+ "function foo() { bar(); }",
+ "asm: line 39: illegal comparison operator\n");
+}
+
+
+TEST(InOperator) {
+ CHECK_FUNC_ERROR(
+ "function bar() { return (0 in 0)|0; }\n"
+ "function foo() { bar(); }",
+ "asm: line 39: illegal comparison operator\n");
+}
+
+
+TEST(LogicalAndOperator) {
+ CHECK_FUNC_ERROR(
+ "function bar() { return (0 && 0)|0; }\n"
+ "function foo() { bar(); }",
+ "asm: line 39: illegal logical operator\n");
+}
+
+
+TEST(LogicalOrOperator) {
+ CHECK_FUNC_ERROR(
+ "function bar() { return (0 || 0)|0; }\n"
+ "function foo() { bar(); }",
+ "asm: line 39: illegal logical operator\n");
+}
+
+
+TEST(BadLiteral) {
+ CHECK_FUNC_ERROR(
+ "function bar() { return true | 0; }\n"
+ "function foo() { bar(); }",
+ "asm: line 39: illegal literal\n");
+}
+
+
TEST(ForeignFunction) {
CHECK_FUNC_TYPES_BEGIN(
"var baz = foreign.baz;\n"
« no previous file with comments | « src/typing-asm.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698