chrome/browser/chromeos/file_system_provider/operations/read_directory_unittest.cc - Issue 1432403003: Do not call stat() when reading directories via File API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/file_system_provider/operations/read_directory_unittest.cc

Issue 1432403003: Do not call stat() when reading directories via File API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed FSP tests. Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/file_system_provider/operations/read_directory.cc ('k') | chrome/browser/media_galleries/fileapi/iphoto_file_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/file_system_provider/operations/read_directory_unittest.cc

diff --git a/chrome/browser/chromeos/file_system_provider/operations/read_directory_unittest.cc b/chrome/browser/chromeos/file_system_provider/operations/read_directory_unittest.cc

index b76399048c18687c7597e57229d955672fee84e8..4c2f2a17ca5659beb6d5c903a05f8c8560accce6 100644

--- a/chrome/browser/chromeos/file_system_provider/operations/read_directory_unittest.cc

+++ b/chrome/browser/chromeos/file_system_provider/operations/read_directory_unittest.cc

@@ -185,11 +185,7 @@ TEST_F(FileSystemProviderOperationsReadDirectoryTest, OnSuccess) {

" [\n"

" {\n"

" \"isDirectory\": false,\n"

- " \"name\": \"blueberries.txt\",\n"

- " \"size\": 4096,\n"

- " \"modificationTime\": {\n"

- " \"value\": \"Thu Apr 24 00:46:52 UTC 2014\"\n"

- " }\n"

+ " \"name\": \"blueberries.txt\"\n"

" }\n"

" ],\n"

" false,\n" // has_more

@@ -209,11 +205,6 @@ TEST_F(FileSystemProviderOperationsReadDirectoryTest, OnSuccess) {

const storage::DirectoryEntry entry = event->entry_list()[0];

EXPECT_FALSE(entry.is_directory);

EXPECT_EQ("blueberries.txt", entry.name);

- EXPECT_EQ(4096, entry.size);

- base::Time expected_time;

- EXPECT_TRUE(

- base::Time::FromString("Thu Apr 24 00:46:52 UTC 2014", &expected_time));

- EXPECT_EQ(expected_time, entry.last_modified_time);

}

TEST_F(FileSystemProviderOperationsReadDirectoryTest,

@@ -241,11 +232,7 @@ TEST_F(FileSystemProviderOperationsReadDirectoryTest,