chrome/browser/chromeos/file_system_provider/operations/read_directory.cc - Issue 1432403003: Do not call stat() when reading directories via File API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/file_system_provider/operations/read_directory.cc

Issue 1432403003: Do not call stat() when reading directories via File API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed FSP tests. Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/file_system_provider/operations/get_metadata_unittest.cc ('k') | chrome/browser/chromeos/file_system_provider/operations/read_directory_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/file_system_provider/operations/read_directory.cc

diff --git a/chrome/browser/chromeos/file_system_provider/operations/read_directory.cc b/chrome/browser/chromeos/file_system_provider/operations/read_directory.cc

index d9f34c16ed03d8f11637bb9551a6e6badb01b930..72ec917cfbd38a3bbdd7b99421bc47189f626ea3 100644

--- a/chrome/browser/chromeos/file_system_provider/operations/read_directory.cc

+++ b/chrome/browser/chromeos/file_system_provider/operations/read_directory.cc

@@ -35,17 +35,6 @@ bool ConvertRequestValueToEntryList(scoped_ptr<RequestValue> value,

storage::DirectoryEntry output_entry;

output_entry.is_directory = entry_metadata->is_directory;

output_entry.name = entry_metadata->name;

- output_entry.size = static_cast<int64>(entry_metadata->size);

- std::string input_modification_time;

- if (!entry_metadata->modification_time.additional_properties.GetString(

- "value", &input_modification_time)) {

- NOTREACHED();

- }

- if (!base::Time::FromString(input_modification_time.c_str(),

- &output_entry.last_modified_time)) {

- NOTREACHED();

- }

output->push_back(output_entry);

}