chrome/browser/chromeos/file_system_provider/operations/get_metadata.cc - Issue 1432403003: Do not call stat() when reading directories via File API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/file_system_provider/operations/get_metadata.cc

Issue 1432403003: Do not call stat() when reading directories via File API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed FSP tests. Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/file_system_provider/fake_provided_file_system.cc ('k') | chrome/browser/chromeos/file_system_provider/operations/get_metadata_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/file_system_provider/operations/get_metadata.cc

diff --git a/chrome/browser/chromeos/file_system_provider/operations/get_metadata.cc b/chrome/browser/chromeos/file_system_provider/operations/get_metadata.cc

index f98a14593e7805b16f64089f61dd58ce5d015ebb..0cc8389e6f2253dd18b284d6019e71e57510c7b4 100644

--- a/chrome/browser/chromeos/file_system_provider/operations/get_metadata.cc

+++ b/chrome/browser/chromeos/file_system_provider/operations/get_metadata.cc

@@ -32,10 +32,10 @@ bool ConvertRequestValueToFileInfo(scoped_ptr<RequestValue> value,

output->name = params->metadata.name;

output->is_directory = params->metadata.is_directory;

- output->size = static_cast<int64>(params->metadata.size);

+ output->size = static_cast<int64>(*params->metadata.size);

std::string input_modification_time;

- if (!params->metadata.modification_time.additional_properties.GetString(

+ if (!params->metadata.modification_time->additional_properties.GetString(

"value", &input_modification_time)) {

NOTREACHED();

}

@@ -65,7 +65,8 @@ bool ValidateIDLEntryMetadata(

return false;

std::string input_modification_time;

- if (!metadata.modification_time.additional_properties.GetString(

+ if (metadata.modification_time.get() &&

+ !metadata.modification_time->additional_properties.GetString(

"value", &input_modification_time)) {

return false;

}