chrome/browser/chromeos/file_system_provider/fake_provided_file_system.cc - Issue 1432403003: Do not call stat() when reading directories via File API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/file_system_provider/fake_provided_file_system.cc

Issue 1432403003: Do not call stat() when reading directories via File API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed FSP tests. Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/drive/fileapi/fileapi_worker.cc ('k') | chrome/browser/chromeos/file_system_provider/operations/get_metadata.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/file_system_provider/fake_provided_file_system.cc

diff --git a/chrome/browser/chromeos/file_system_provider/fake_provided_file_system.cc b/chrome/browser/chromeos/file_system_provider/fake_provided_file_system.cc

index d218101220613bd412b03e8aaea52fb00866842d..fb3fce5623dbaca8d0dff4e982e7ea745f92afd7 100644

--- a/chrome/browser/chromeos/file_system_provider/fake_provided_file_system.cc

+++ b/chrome/browser/chromeos/file_system_provider/fake_provided_file_system.cc

@@ -136,11 +136,9 @@ AbortCallback FakeProvidedFileSystem::ReadDirectory(

if (file_path == directory_path || directory_path.IsParent(file_path)) {

const EntryMetadata* const metadata = it->second->metadata.get();

entry_list.push_back(storage::DirectoryEntry(

- metadata->name,

- metadata->is_directory ? storage::DirectoryEntry::DIRECTORY

- : storage::DirectoryEntry::FILE,

- metadata->size,

- metadata->modification_time));

+ metadata->name, metadata->is_directory

+ ? storage::DirectoryEntry::DIRECTORY

+ : storage::DirectoryEntry::FILE));

}