Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issue 14323008: Always use -gline-tables-only when building with ThreadSanitizer v2 (Closed)

Created:
7 years, 8 months ago by Alexander Potapenko
Modified:
7 years, 8 months ago
Reviewers:
Nico
CC:
chromium-reviews
Visibility:
Public.

Description

Always use -gline-tables-only when building with ThreadSanitizer v2 BUG=128314 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195149

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -4 lines) Patch
M build/common.gypi View 1 2 3 chunks +12 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Alexander Potapenko
PTAL
7 years, 8 months ago (2013-04-17 08:05:08 UTC) #1
Nico
lgtm. the asan tsan msan blocks look pretty similar… https://codereview.chromium.org/14323008/diff/1/build/common.gypi File build/common.gypi (right): https://codereview.chromium.org/14323008/diff/1/build/common.gypi#newcode3028 build/common.gypi:3028: ...
7 years, 8 months ago (2013-04-17 16:46:21 UTC) #2
Alexander Potapenko
https://codereview.chromium.org/14323008/diff/1/build/common.gypi File build/common.gypi (right): https://codereview.chromium.org/14323008/diff/1/build/common.gypi#newcode3028 build/common.gypi:3028: '-fPIC', On 2013/04/17 16:46:21, Nico wrote: > Here too? ...
7 years, 8 months ago (2013-04-18 11:56:58 UTC) #3
Nico
Thanks, still lgtm
7 years, 8 months ago (2013-04-18 17:37:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/glider@chromium.org/14323008/15001
7 years, 8 months ago (2013-04-18 17:48:12 UTC) #5
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 8 months ago (2013-04-18 17:58:20 UTC) #6
Alexander Potapenko
Committed patchset #3 manually as r195149 (presubmit successful).
7 years, 8 months ago (2013-04-19 13:00:57 UTC) #7
Alexander Potapenko
7 years, 8 months ago (2013-04-19 13:07:01 UTC) #8
Message was sent while issue was closed.
On 2013/04/19 13:00:57, Alexander Potapenko wrote:
> Committed patchset #3 manually as r195149 (presubmit successful).

Argh, forgot to mention MSan in the issue description.

Powered by Google App Engine
This is Rietveld 408576698