Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Unified Diff: build/common.gypi

Issue 14323008: Always use -gline-tables-only when building with ThreadSanitizer v2 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
===================================================================
--- build/common.gypi (revision 195091)
+++ build/common.gypi (working copy)
@@ -2975,14 +2975,24 @@
'-fcolor-diagnostics',
],
}],
+ # Common options for AddressSanitizer, ThreadSanitizer and
+ # MemorySanitizer.
+ ['asan==1 or tsan==1 or msan==1', {
+ 'target_conditions': [
+ ['_toolset=="target"', {
+ 'cflags': [
+ '-fno-omit-frame-pointer',
+ '-gline-tables-only',
+ ],
+ }],
+ ],
+ }],
['asan==1', {
'target_conditions': [
['_toolset=="target"', {
'cflags': [
'-fsanitize=address',
- '-fno-omit-frame-pointer',
'-w', # http://crbug.com/162783
- '-gline-tables-only',
],
'ldflags': [
'-fsanitize=address',
@@ -3005,7 +3015,6 @@
['_toolset=="target"', {
'cflags': [
'-fsanitize=thread',
- '-fno-omit-frame-pointer',
'-fPIC',
'-mllvm', '-tsan-blacklist=<(tsan_blacklist)',
],
@@ -3033,7 +3042,6 @@
'cflags': [
'-fsanitize=memory',
'-fsanitize-memory-track-origins',
- '-fno-omit-frame-pointer',
'-fPIC',
],
'ldflags': [
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698