Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(497)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 143223005: Fix broken debug build (Closed)

Created:
6 years, 10 months ago by iancottrell
Modified:
6 years, 10 months ago
Reviewers:
tomhudson
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@no_external_test
Visibility:
Public.

Description

Fix broken debug build BUG=skia: Committed: http://code.google.com/p/skia/source/detail?r=13397

Patch Set 1 #

Patch Set 2 : Remove invalid private implementation detail tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -13 lines) Patch
M src/core/SkWriter32.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/Writer32Test.cpp View 1 1 chunk +3 lines, -11 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
iancottrell
I broke the debug build with http://code.google.com/p/skia/source/detail?r=13396 This is the fix...
6 years, 10 months ago (2014-02-11 10:45:16 UTC) #1
tomhudson
FAILED: ../tests/Writer32Test.cpp:210 writer.contiguousArray() == NULL
6 years, 10 months ago (2014-02-11 10:48:15 UTC) #2
tomhudson
On 2014/02/11 10:48:15, tomhudson wrote: > FAILED: ../tests/Writer32Test.cpp:210 writer.contiguousArray() == NULL I have created a ...
6 years, 10 months ago (2014-02-11 10:56:09 UTC) #3
iancottrell
6 years, 10 months ago (2014-02-11 11:07:36 UTC) #4
tomhudson
lgtm
6 years, 10 months ago (2014-02-11 11:08:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/iancottrell@google.com/143223005/50001
6 years, 10 months ago (2014-02-11 11:08:20 UTC) #6
commit-bot: I haz the power
6 years, 10 months ago (2014-02-11 11:18:15 UTC) #7
Message was sent while issue was closed. 
Change committed as 13397

Powered by Google App Engine
This is Rietveld 408576698