Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1483)

Unified Diff: tests/Writer32Test.cpp

Issue 143223005: Fix broken debug build (Closed) Base URL: https://skia.googlesource.com/skia.git@no_external_test
Patch Set: Remove invalid private implementation detail tests Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/core/SkWriter32.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/Writer32Test.cpp
diff --git a/tests/Writer32Test.cpp b/tests/Writer32Test.cpp
index 2f8b5c6edff8048897c4a32e5332e998d7cfde71..4d421c806029004bdf512e805dd1dfe9df2d5fc1 100644
--- a/tests/Writer32Test.cpp
+++ b/tests/Writer32Test.cpp
@@ -203,17 +203,9 @@ DEF_TEST(Writer32_contiguous, reporter) {
test1(reporter, &writer);
REPORTER_ASSERT(reporter, writer.contiguousArray() != NULL);
- // This write is too big for the 32 byte storage block we provide.
- writer.reset(storage, 32);
- test2(reporter, &writer);
- // Some data is in storage, some in writer's internal storage.
- REPORTER_ASSERT(reporter, writer.contiguousArray() == NULL);
-
- writer.reset();
- test2(reporter, &writer);
- // There is no external storage. All the data is in internal storage,
- // so we can always read it contiguously.
- REPORTER_ASSERT(reporter, writer.contiguousArray() != NULL);
+ // Everything other aspect of contiguous/non-contiguous is an
+ // implementation detail, not part of the public contract for
+ // SkWriter32, and so not tested here.
}
DEF_TEST(Writer32_small, reporter) {
« no previous file with comments | « src/core/SkWriter32.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698