Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 1432213002: MockImageResourceClient: tidy up Resource reference. (Closed)

Created:
5 years, 1 month ago by sof
Modified:
5 years, 1 month ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, blink-reviews, loading-reviews+fetch_chromium.org, tyoshino+watch_chromium.org, Nate Chapin, gavinp+loader_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MockImageResourceClient: tidy up Resource reference. R=haraken BUG=503485 Committed: https://crrev.com/841aaef1ff544e4b09f2f4fb3a0d1fa12a30308b Cr-Commit-Position: refs/heads/master@{#359083}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M third_party/WebKit/Source/core/fetch/MockImageResourceClient.h View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
sof
please take a look.
5 years, 1 month ago (2015-11-11 10:51:34 UTC) #2
haraken
LGTM Yeah, moving ResourceClient to the heap would be a TODO.
5 years, 1 month ago (2015-11-11 11:24:05 UTC) #3
sof
On 2015/11/11 11:24:05, haraken wrote: > LGTM > > Yeah, moving ResourceClient to the heap ...
5 years, 1 month ago (2015-11-11 11:39:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1432213002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1432213002/1
5 years, 1 month ago (2015-11-11 12:02:59 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-11 12:07:14 UTC) #8
commit-bot: I haz the power
5 years, 1 month ago (2015-11-11 12:08:19 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/841aaef1ff544e4b09f2f4fb3a0d1fa12a30308b
Cr-Commit-Position: refs/heads/master@{#359083}

Powered by Google App Engine
This is Rietveld 408576698