Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Side by Side Diff: third_party/WebKit/Source/core/fetch/MockImageResourceClient.h

Issue 1432213002: MockImageResourceClient: tidy up Resource reference. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2013, Google Inc. All rights reserved. 2 * Copyright (c) 2013, Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 14 matching lines...) Expand all
25 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY 25 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
26 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 26 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
29 */ 29 */
30 30
31 #ifndef MockImageResourceClient_h 31 #ifndef MockImageResourceClient_h
32 #define MockImageResourceClient_h 32 #define MockImageResourceClient_h
33 33
34 #include "core/fetch/ImageResourceClient.h" 34 #include "core/fetch/ImageResourceClient.h"
35 #include "platform/heap/Handle.h"
35 36
36 namespace blink { 37 namespace blink {
37 38
38 template<typename T> class ResourcePtr; 39 template<typename T> class ResourcePtr;
39 40
40 class Resource; 41 class Resource;
41 42
42 class MockImageResourceClient final : public ImageResourceClient { 43 class MockImageResourceClient final : public ImageResourceClient {
43 public: 44 public:
44 explicit MockImageResourceClient(const ResourcePtr<Resource>&); 45 explicit MockImageResourceClient(const ResourcePtr<Resource>&);
45 ~MockImageResourceClient() override; 46 ~MockImageResourceClient() override;
46 47
47 void imageChanged(ImageResource*, const IntRect*) override 48 void imageChanged(ImageResource*, const IntRect*) override
48 { 49 {
49 m_imageChangedCount++; 50 m_imageChangedCount++;
50 } 51 }
51 52
52 void notifyFinished(Resource*) override; 53 void notifyFinished(Resource*) override;
53 String debugName() const override { return "MockImageResourceClient"; } 54 String debugName() const override { return "MockImageResourceClient"; }
54 55
55 int imageChangedCount() const { return m_imageChangedCount; } 56 int imageChangedCount() const { return m_imageChangedCount; }
56 bool notifyFinishedCalled() const { return m_notifyFinishedCalled; } 57 bool notifyFinishedCalled() const { return m_notifyFinishedCalled; }
57 58
58 void removeAsClient(); 59 void removeAsClient();
59 60
60 private: 61 private:
61 Resource* m_resource; 62 // TODO(Oilpan): properly trace when ImageResourceClient is on the heap.
63 RawPtrWillBeUntracedMember<Resource> m_resource;
62 int m_imageChangedCount; 64 int m_imageChangedCount;
63 bool m_notifyFinishedCalled; 65 bool m_notifyFinishedCalled;
64 }; 66 };
65 67
66 } // namespace blink 68 } // namespace blink
67 69
68 #endif // MockImageResourceClient_h 70 #endif // MockImageResourceClient_h
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698