Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Unified Diff: webkit/glue/multi_resolution_image_resource_fetcher.h

Issue 14322023: Don't request missing favicon on every page request. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Propagate HTTP Status Code to FaviconTabHelper::DidDownloadFavicon, Clear Missing Favicons on RELOA… Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webkit/glue/multi_resolution_image_resource_fetcher.h
diff --git a/webkit/glue/multi_resolution_image_resource_fetcher.h b/webkit/glue/multi_resolution_image_resource_fetcher.h
index b3164331bb169556f3e922b4d04e3eaa2c7eaf55..d300611166c4a7e47199db6950fd7c29a9454630 100644
--- a/webkit/glue/multi_resolution_image_resource_fetcher.h
+++ b/webkit/glue/multi_resolution_image_resource_fetcher.h
@@ -38,6 +38,9 @@ class MultiResolutionImageResourceFetcher{
// Unique identifier for the request.
int id() const { return id_; }
+ // HTTP status code upon fetch completion.
+ int http_status_code() { return http_status_code_; }
sky 2013/05/03 20:24:54 const?
mef 2013/05/03 21:45:59 Done.
+
private:
// ResourceFetcher::Callback. Decodes the image and invokes callback_.
void OnURLFetchComplete(const WebKit::WebURLResponse& response,
@@ -48,6 +51,9 @@ class MultiResolutionImageResourceFetcher{
// Unique identifier for the request.
const int id_;
+ // HTTP status code upon fetch completion.
+ int http_status_code_;
+
// URL of the image.
const GURL image_url_;

Powered by Google App Engine
This is Rietveld 408576698