Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1668)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: content/renderer/image_loading_helper.cc

Issue 14322023: Don't request missing favicon on every page request. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Propagate HTTP Status Code to FaviconTabHelper::DidDownloadFavicon, Clear Missing Favicons on RELOA… Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/favicon/favicon_tab_helper.cc ('K') | « content/public/browser/web_contents.h ('k') | webkit/glue/multi_resolution_image_resource_fetcher.h » ('j') | webkit/glue/multi_resolution_image_resource_fetcher.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/image_loading_helper.cc
diff --git a/content/renderer/image_loading_helper.cc b/content/renderer/image_loading_helper.cc
index c996984af9bbf34a4629a65e306d91f032cbefdd..bb2b3a5c0b007b057ea3d95b88f2c92122cf414f 100644
--- a/content/renderer/image_loading_helper.cc
+++ b/content/renderer/image_loading_helper.cc
@@ -54,6 +54,7 @@ void ImageLoadingHelper::OnDownloadImage(int id,
Send(new ImageHostMsg_DidDownloadImage(routing_id(),
id,
+ 0,
sky 2013/05/03 20:24:54 Is 0 right here?
mef 2013/05/03 21:45:59 I think it is more correct than 200, as no request
image_url,
image_size,
result_images));
@@ -85,6 +86,7 @@ void ImageLoadingHelper::DidDownloadImage(
// Notify requester of image download status.
Send(new ImageHostMsg_DidDownloadImage(routing_id(),
fetcher->id(),
+ fetcher->http_status_code(),
fetcher->image_url(),
requested_size,
images));
« chrome/browser/favicon/favicon_tab_helper.cc ('K') | « content/public/browser/web_contents.h ('k') | webkit/glue/multi_resolution_image_resource_fetcher.h » ('j') | webkit/glue/multi_resolution_image_resource_fetcher.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698