content/browser/web_contents/web_contents_impl.cc - Issue 14322023: Don't request missing favicon on every page request.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/web_contents_impl.cc

Issue 14322023: Don't request missing favicon on every page request. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Propagate HTTP Status Code to FaviconTabHelper::DidDownloadFavicon, Clear Missing Favicons on RELOA… Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/web_contents/web_contents_impl.cc

diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc

index 43ec8e581e47467e292228b338ab5123f4179980..eedb050c859f02c49e5d7fd6aa3b2a3f3b930f6b 100644

--- a/content/browser/web_contents/web_contents_impl.cc

+++ b/content/browser/web_contents/web_contents_impl.cc

@@ -2403,6 +2403,7 @@ void WebContentsImpl::OnBrowserPluginMessage(const IPC::Message& message) {

void WebContentsImpl::OnDidDownloadImage(

int id,

+ int http_status_code,

const GURL& image_url,

int requested_size,

const std::vector<SkBitmap>& bitmaps) {

@@ -2413,7 +2414,7 @@ void WebContentsImpl::OnDidDownloadImage(

return;

}

if (!iter->second.is_null()) {

- iter->second.Run(id, image_url, requested_size, bitmaps);

+ iter->second.Run(id, http_status_code, image_url, requested_size, bitmaps);

}

image_download_map_.erase(id);

}