Remove unused ImportProgressDialog.

Remove unused ImportProgressDialog.

There was only one Windows-specific/first-run code path for this dialog to be shown, but the first run import should be always silent, and I've run first run many times and have never seen this dialog (the import is probably too fast) anyways.
jeffreyc@ gave the go to kill it at https://code.google.com/p/chromium/issues/detail?id=219419#c3

This is a precursor CL to https://codereview.chromium.org/12670013/

TBR=ben@chromium.org
BUG=219419
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=196072

[gab, 2013-04-17 02:41:01]

Carlos, please take a look.

Cheers,
Gab

https://codereview.chromium.org/14322002/diff/1/chrome/browser/first_run/firs...
File chrome/browser/first_run/first_run.cc (right):

https://codereview.chromium.org/14322002/diff/1/chrome/browser/first_run/firs...
chrome/browser/first_run/first_run.cc:218:
scoped_ptr<first_run::internal::ImportEndedObserver> observer(
Note: This code has the exact same logic as ImportSettings in first_run_posix.cc
and the two will be merged in a helper method in a follow-up CL leading to
https://codereview.chromium.org/12670013/

https://codereview.chromium.org/14322002/diff/1/chrome/browser/first_run/firs...
File chrome/browser/first_run/first_run_internal.h (right):

https://codereview.chromium.org/14322002/diff/1/chrome/browser/first_run/firs...
chrome/browser/first_run/first_run_internal.h:115: class ImportEndedObserver :
public importer::ImporterProgressObserver {
Note: This was moved (unmodified) from first_run_posix.cc

[cpu_(ooo_6.6-7.5), 2013-04-17 21:35:20]

https://codereview.chromium.org/14322002/diff/4002/chrome/browser/first_run/f...
File chrome/browser/first_run/first_run.cc (right):

https://codereview.chromium.org/14322002/diff/4002/chrome/browser/first_run/f...
chrome/browser/first_run/first_run.cc:202: // Imports bookmarks from an html
file. The path to the file is provided in
is comment of line 202 correct?

https://codereview.chromium.org/14322002/diff/4002/chrome/browser/first_run/f...
chrome/browser/first_run/first_run.cc:228: }
it seems the observer can be allocated in the stack?

https://codereview.chromium.org/14322002/diff/4002/chrome/browser/first_run/f...
File chrome/browser/first_run/first_run_internal.h (right):

https://codereview.chromium.org/14322002/diff/4002/chrome/browser/first_run/f...
chrome/browser/first_run/first_run_internal.h:64: void
set_should_quit_message_loop() {
const

https://codereview.chromium.org/14322002/diff/4002/chrome/browser/first_run/f...
chrome/browser/first_run/first_run_internal.h:68: bool ended() {
const

[gab, 2013-04-18 14:51:56]

PTAL.

Thanks,
Gab

https://codereview.chromium.org/14322002/diff/4002/chrome/browser/first_run/f...
File chrome/browser/first_run/first_run.cc (right):

https://codereview.chromium.org/14322002/diff/4002/chrome/browser/first_run/f...
chrome/browser/first_run/first_run.cc:202: // Imports bookmarks from an html
file. The path to the file is provided in
On 2013/04/17 21:35:20, cpu wrote:
> is comment of line 202 correct?

For now yes, this is currently provided on the command line of the import
process.

This will change as part of getting rid of the import process.

https://codereview.chromium.org/14322002/diff/4002/chrome/browser/first_run/f...
chrome/browser/first_run/first_run.cc:228: }
On 2013/04/17 21:35:20, cpu wrote:
> it seems the observer can be allocated in the stack?

Definitely, also changed the call site this was copied from (note that this
copy/pasted code will all land in a common method in first_run.cc in
https://codereview.chromium.org/12670013).

https://codereview.chromium.org/14322002/diff/4002/chrome/browser/first_run/f...
File chrome/browser/first_run/first_run_internal.h (right):

https://codereview.chromium.org/14322002/diff/4002/chrome/browser/first_run/f...
chrome/browser/first_run/first_run_internal.h:64: void
set_should_quit_message_loop() {
On 2013/04/17 21:35:20, cpu wrote:
> const

This is not const.

https://codereview.chromium.org/14322002/diff/4002/chrome/browser/first_run/f...
chrome/browser/first_run/first_run_internal.h:68: bool ended() {
On 2013/04/17 21:35:20, cpu wrote:
> const

Done.

[cpu_(ooo_6.6-7.5), 2013-04-18 20:06:37]

most excellent sir.

lgtm

[gab, 2013-04-18 20:41:43]

Miranda, can you take a look, you own most of the code being removed :)!

Thanks,
Gab

[gab, 2013-04-22 18:11:58]

@mirandac: ping

[Miranda Callahan, 2013-04-23 07:10:29]

Great change -- LGTM!

https://codereview.chromium.org/14322002/diff/10001/chrome/browser/first_run/...
File chrome/browser/first_run/first_run.cc (right):

https://codereview.chromium.org/14322002/diff/10001/chrome/browser/first_run/...
chrome/browser/first_run/first_run.cc:413: return true;
The original return value reflects the fact that importing from a file could go
horribly wrong, though, doesn't it? Don't we still need to protect against that
admittedly remote eventuality, even though this function is going away soon?

[Miranda Callahan, 2013-04-23 07:17:49]

Oh, one more thing -- it looks like there is a WaitForImport problem on the Win
bot that needs to be fixed?

On 2013/04/23 07:10:29, Miranda Callahan wrote:
> Great change -- LGTM!
> 
>
https://codereview.chromium.org/14322002/diff/10001/chrome/browser/first_run/...
> File chrome/browser/first_run/first_run.cc (right):
> 
>
https://codereview.chromium.org/14322002/diff/10001/chrome/browser/first_run/...
> chrome/browser/first_run/first_run.cc:413: return true;
> The original return value reflects the fact that importing from a file could
go
> horribly wrong, though, doesn't it? Don't we still need to protect against
that
> admittedly remote eventuality, even though this function is going away soon?

[gab, 2013-04-23 15:26:07]

Thanks, looking into WaitForImport.

https://codereview.chromium.org/14322002/diff/10001/chrome/browser/first_run/...
File chrome/browser/first_run/first_run.cc (right):

https://codereview.chromium.org/14322002/diff/10001/chrome/browser/first_run/...
chrome/browser/first_run/first_run.cc:413: return true;
On 2013/04/23 07:10:29, Miranda Callahan wrote:
> The original return value reflects the fact that importing from a file could
go
> horribly wrong, though, doesn't it? Don't we still need to protect against
that
> admittedly remote eventuality, even though this function is going away soon?

ImportFromFile will be done OOP as part of
https://codereview.chromium.org/12670013/ and the OOP importer doesn't have
error reporting.

[gab, 2013-04-23 15:28:18]

https://codereview.chromium.org/14322002/diff/10001/chrome/browser/first_run/...
File chrome/browser/first_run/first_run.cc (right):

https://codereview.chromium.org/14322002/diff/10001/chrome/browser/first_run/...
chrome/browser/first_run/first_run.cc:413: return true;
On 2013/04/23 15:26:07, gab wrote:
> On 2013/04/23 07:10:29, Miranda Callahan wrote:
> > The original return value reflects the fact that importing from a file could
> go
> > horribly wrong, though, doesn't it? Don't we still need to protect against
> that
> > admittedly remote eventuality, even though this function is going away soon?
> 
> ImportFromFile will be done OOP as part of
> https://codereview.chromium.org/12670013/ and the OOP importer doesn't have
> error reporting.

Ref:
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/fir...

[commit-bot: I haz the power, 2013-04-23 22:35:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gab@chromium.org/14322002/25001

[commit-bot: I haz the power, 2013-04-23 22:35:22]

Presubmit check for 14322002-25001 failed and returned exit status 1.

INFO:root:Found 9 file(s).

Running presubmit commit checks ...
Running /b/commit-queue/workdir/chromium/PRESUBMIT.py
Running /b/commit-queue/workdir/chromium/chrome/PRESUBMIT.py
Running /b/commit-queue/workdir/chromium/chrome/browser/ui/views/PRESUBMIT.py

** Presubmit ERRORS **
Missing LGTM from an OWNER for these files:
    chrome/browser/ui/views/stubs_aura.cc
    chrome/chrome_browser.gypi
    chrome/chrome_browser_ui.gypi
    chrome/chrome_nibs.gyp

Presubmit checks took 1.0s to calculate.

[gab, 2013-04-23 22:40:56]

FTR, the issue with WaitForImport was that I had changed ImportFromBrowser from
returning an int to a bool (however it was still handled as a return code (where
success is defined as RESULT_CODE_NORMAL_EXIT (i.e. 0), but "true" is not 0...).

bool and int "nicely" convert to one another in C++ with no warning so I had
missed that.

That method is going away and the return type is really irrelevant for the
remaining time it has to live in the source (and FWIW, the method was already
only returning RESULT_CODE_NORMAL_EXIT since that's all FirstRunImportObserver
would use...).

Cheers!
Gab

[commit-bot: I haz the power, 2013-04-23 22:41:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gab@chromium.org/14322002/25001

[commit-bot: I haz the power, 2013-04-23 22:41:22]

Presubmit check for 14322002-25001 failed and returned exit status 1.

INFO:root:Found 9 file(s).

Running presubmit commit checks ...
Running /b/commit-queue/workdir/chromium/PRESUBMIT.py
Running /b/commit-queue/workdir/chromium/chrome/PRESUBMIT.py
Running /b/commit-queue/workdir/chromium/chrome/browser/ui/views/PRESUBMIT.py

** Presubmit ERRORS **
Missing LGTM from an OWNER for these files:
    chrome/browser/ui/views/stubs_aura.cc
    chrome/chrome_browser.gypi
    chrome/chrome_browser_ui.gypi
    chrome/chrome_nibs.gyp

Presubmit checks took 1.1s to calculate.

[gab, 2013-04-23 22:44:22]

TBR ben for gyp changes and small side-effects in stubs_aura.cc

    chrome/browser/ui/views/stubs_aura.cc
    chrome/chrome_browser.gypi
    chrome/chrome_browser_ui.gypi
    chrome/chrome_nibs.gyp

Thanks,
Gab

On 2013/04/23 22:41:22, I haz the power (commit-bot) wrote:
> Presubmit check for 14322002-25001 failed and returned exit status 1.
> 
> INFO:root:Found 9 file(s).
> 
> Running presubmit commit checks ...
> Running /b/commit-queue/workdir/chromium/PRESUBMIT.py
> Running /b/commit-queue/workdir/chromium/chrome/PRESUBMIT.py
> Running /b/commit-queue/workdir/chromium/chrome/browser/ui/views/PRESUBMIT.py
> 
> ** Presubmit ERRORS **
> Missing LGTM from an OWNER for these files:
>     chrome/browser/ui/views/stubs_aura.cc
>     chrome/chrome_browser.gypi
>     chrome/chrome_browser_ui.gypi
>     chrome/chrome_nibs.gyp
> 
> Presubmit checks took 1.1s to calculate.

[commit-bot: I haz the power, 2013-04-23 22:45:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gab@chromium.org/14322002/25001

[commit-bot: I haz the power, 2013-04-24 07:29:54]

Change committed as 196072