chrome/browser/ui/cocoa/web_dialog_window_controller.mm - Issue 1432143002: Track where WebContents are created in order to better understand issue.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/web_dialog_window_controller.mm

Issue 1432143002: Track where WebContents are created in order to better understand issue. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« blimp/engine/browser/blimp_engine_session.cc ('K') | « chrome/browser/ui/cocoa/profiles/user_manager_mac.mm ('k') | chrome/browser/ui/panels/panel_host.cc » ('j') | chromecast/browser/cast_content_window.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/web_dialog_window_controller.mm

diff --git a/chrome/browser/ui/cocoa/web_dialog_window_controller.mm b/chrome/browser/ui/cocoa/web_dialog_window_controller.mm

index 1180f952ab0543e3b59582b5eadf1df36eebe467..b0915f3867824b08e34ba21fcf4a2b79db6a3bfb 100644

--- a/chrome/browser/ui/cocoa/web_dialog_window_controller.mm

+++ b/chrome/browser/ui/cocoa/web_dialog_window_controller.mm

@@ -12,6 +12,7 @@

#include "chrome/browser/ui/webui/chrome_web_contents_handler.h"

#include "content/public/browser/native_web_keyboard_event.h"

#include "content/public/browser/web_contents.h"

+#include "content/public/browser/web_contents_source.h"

#include "content/public/browser/web_ui_message_handler.h"

#include "ui/events/keycodes/keyboard_codes.h"

#include "ui/gfx/geometry/size.h"

@@ -322,6 +323,8 @@ void WebDialogWindowDelegateBridge::HandleKeyboardEvent(

- (void)loadDialogContents {

webContents_.reset(WebContents::Create(

WebContents::CreateParams(delegate_->browser_context())));

+ WebContentsSource::CreateForWebContentsAndLocation(webContents_.get(),

+ FROM_HERE);

[[self window] setContentView:webContents_->GetNativeView()];

webContents_->SetDelegate(delegate_.get());