chrome/browser/ui/browser_navigator.cc - Issue 1432143002: Track where WebContents are created in order to better understand issue.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/browser_navigator.cc

Issue 1432143002: Track where WebContents are created in order to better understand issue. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« blimp/engine/browser/blimp_engine_session.cc ('K') | « chrome/browser/ui/app_list/start_page_service.cc ('k') | chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm » ('j') | chromecast/browser/cast_content_window.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/browser_navigator.cc

diff --git a/chrome/browser/ui/browser_navigator.cc b/chrome/browser/ui/browser_navigator.cc

index d5573b14822ddbe78021bebb66e63591bfd47f61..b1c144e652bdfd32f57a5f9c641f70ec3076a9a5 100644

--- a/chrome/browser/ui/browser_navigator.cc

+++ b/chrome/browser/ui/browser_navigator.cc

@@ -36,6 +36,7 @@

#include "content/public/browser/notification_service.h"

#include "content/public/browser/render_view_host.h"

#include "content/public/browser/web_contents.h"

+#include "content/public/browser/web_contents_source.h"

#if defined(USE_ASH)

#include "chrome/browser/ui/ash/multi_user/multi_user_window_manager.h"

@@ -371,6 +372,8 @@ content::WebContents* CreateTargetContents(const chrome::NavigateParams& params,

#endif

WebContents* target_contents = WebContents::Create(create_params);

+ WebContentsSource::CreateForWebContentsAndLocation(target_contents,

+ FROM_HERE);

// New tabs can have WebUI URLs that will make calls back to arbitrary

// tab helpers, so the entire set of tab helpers needs to be set up