chrome/browser/sessions/session_restore_android.cc - Issue 1432143002: Track where WebContents are created in order to better understand issue.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sessions/session_restore_android.cc

Issue 1432143002: Track where WebContents are created in order to better understand issue. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« blimp/engine/browser/blimp_engine_session.cc ('K') | « chrome/browser/memory/tab_manager.cc ('k') | chrome/browser/ui/app_list/start_page_service.cc » ('j') | chromecast/browser/cast_content_window.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sessions/session_restore_android.cc

diff --git a/chrome/browser/sessions/session_restore_android.cc b/chrome/browser/sessions/session_restore_android.cc

index 5bce046309e76603c5256b24bae3b61211c4d807..dfcbef34c6393a9e2f6b26fd1e9e7c7e6e35d2e1 100644

--- a/chrome/browser/sessions/session_restore_android.cc

+++ b/chrome/browser/sessions/session_restore_android.cc

@@ -18,6 +18,7 @@

#include "content/public/browser/navigation_controller.h"

#include "content/public/browser/navigation_entry.h"

#include "content/public/browser/web_contents.h"

+#include "content/public/browser/web_contents_source.h"

// The android implementation does not do anything "foreign session" specific.

// We use it to restore tabs from "recently closed" too.

@@ -36,6 +37,8 @@ content::WebContents* SessionRestore::RestoreForeignSessionTab(

session_tab.navigations, profile);

content::WebContents* new_web_contents = content::WebContents::Create(

content::WebContents::CreateParams(context));

+ WebContentsSource::CreateForWebContentsAndLocation(new_web_contents,

+ FROM_HERE);

int selected_index = session_tab.normalized_navigation_index();

new_web_contents->GetController().Restore(

selected_index,