chrome/browser/extensions/bookmark_app_helper.cc - Issue 1432143002: Track where WebContents are created in order to better understand issue.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/bookmark_app_helper.cc

Issue 1432143002: Track where WebContents are created in order to better understand issue. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« blimp/engine/browser/blimp_engine_session.cc ('K') | « chrome/browser/extensions/api/tabs/ash_panel_contents.cc ('k') | chrome/browser/extensions/webstore_install_with_prompt.cc » ('j') | chromecast/browser/cast_content_window.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/bookmark_app_helper.cc

diff --git a/chrome/browser/extensions/bookmark_app_helper.cc b/chrome/browser/extensions/bookmark_app_helper.cc

index d2e8ee10d2af7f720a7e4eb0541012667ea44152..604a054d4e9557fe0fbc1d4d27fed3534307479e 100644

--- a/chrome/browser/extensions/bookmark_app_helper.cc

+++ b/chrome/browser/extensions/bookmark_app_helper.cc

@@ -31,6 +31,7 @@

#include "content/public/browser/notification_service.h"

#include "content/public/browser/notification_source.h"

#include "content/public/browser/web_contents.h"

+#include "content/public/browser/web_contents_source.h"

#include "extensions/browser/extension_registry.h"

#include "extensions/browser/extension_system.h"

#include "extensions/browser/image_loader.h"

@@ -249,6 +250,8 @@ class BookmarkAppInstaller : public base::RefCounted<BookmarkAppInstaller>,

// first sign-in to a new machine.

web_contents_.reset(content::WebContents::Create(

content::WebContents::CreateParams(service_->profile())));

+ WebContentsSource::CreateForWebContentsAndLocation(web_contents_.get(),

+ FROM_HERE);

Observe(web_contents_.get());

// Load about:blank so that the process actually starts.