Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2922)

Unified Diff: android_webview/lib/aw_browser_dependency_factory_impl.cc

Issue 1432143002: Track where WebContents are created in order to better understand issue. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | android_webview/native/aw_contents.cc » ('j') | blimp/engine/browser/blimp_engine_session.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/lib/aw_browser_dependency_factory_impl.cc
diff --git a/android_webview/lib/aw_browser_dependency_factory_impl.cc b/android_webview/lib/aw_browser_dependency_factory_impl.cc
index b054881cbe45fb182a0e10a339edbab39f96cb5f..7c4abb3443811b47acecdd30d84dce45d9e340f9 100644
--- a/android_webview/lib/aw_browser_dependency_factory_impl.cc
+++ b/android_webview/lib/aw_browser_dependency_factory_impl.cc
@@ -9,6 +9,7 @@
#include "base/lazy_instance.h"
#include "content/public/browser/content_browser_client.h"
#include "content/public/browser/web_contents.h"
+#include "content/public/browser/web_contents_source.h"
#include "content/public/common/content_client.h"
using content::BrowserContext;
@@ -36,8 +37,10 @@ content::BrowserContext* AwBrowserDependencyFactoryImpl::GetBrowserContext() {
}
WebContents* AwBrowserDependencyFactoryImpl::CreateWebContents() {
- return content::WebContents::Create(
+ content::WebContents* web_contents = content::WebContents::Create(
content::WebContents::CreateParams(GetBrowserContext()));
+ WebContentsSource::CreateForWebContentsAndLocation(web_contents, FROM_HERE);
Mike Wittman 2015/11/11 17:15:28 Web contents modal dialogs aren't supported on And
hcarmona 2015/11/11 19:57:57 Done.
+ return web_contents;
}
} // namespace android_webview
« no previous file with comments | « no previous file | android_webview/native/aw_contents.cc » ('j') | blimp/engine/browser/blimp_engine_session.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698